Skip to content
OverviewSolutions
4
Comments
2
Tommy Tabe
@tabetommy

All comments

  • Tommy Tabe•150
    @tabetommyPosted almost 2 years ago

    Hi Roshan, your solution look good and functional. But there seem to be one step you perhaps missed and it's that when a user opens the app, it should querry and display the information about the users's IP adress. I think once that's adjusted then your solution will be top notch. I think you have to grab the clients ip address on load , there's an acticle on that for ipify https://www.geeksforgeeks.org/how-to-get-client-ip-address-using-javascript/

    Marked as helpful
    0
  • Tommy Tabe•150
    @tabetommyPosted almost 2 years ago

    Your solution looks really good especially the improvised box at the right showing the route planner linking to google map. It will be really look closer to the given design if you adjust the UI containing the IP address informations to the center of the border between the map view and background image at the top. You could use position relative for parent container and position absolute for child container to achieve this. Also, frontend mentor platform reports an error on your iframe element. something about attribute loading not allowwed. Honestly i don't know much about that but you can check.Otherwise i think your solution looks really good, functional and responsive

    Marked as helpful
    1