I hope this is a joke because this looks close to the original!
I just reviewed your code and here are my thoughts:
I see that you have started using rem
for some of your units. This is a great start for you to get really fluid designs. However, I was kinda wondering why you did not apply the same process for your container widths (you still used px).
My suggestion here is to really understand what your rem
size is. By default (I think) it's 16px. There is a trick to make it easier for you to think in rem
- It's hard to calculate 1rem = 16px, 2rem = 32px
and so on. So you might want to define:
html {
font-size: 62.5%
}
What this does
This makes so that every time you use 1rem anywhere on your project, it now refers not to 16px
, but 10px
! So 1rem = 10px, 2rem = 20px
and so on. Easier right?
Other suggestions
- In general, start with the overall layout when designing your element. As much as possible, start with the bigger designs, such as the card - and set the overall padding and margins of the element.
- When moving to smaller components, such as the buttons, look for commonalities. For instance, the vertical spacing is equal among all the buttons - except for the last one. I would probably implement something like this:
.your-list-selector:not(:last-child) {
margin-bottom: value
}
This way, you are maintaining the integrity of your card styles without having to worry about how the smaller elements interfere with it.
Hope these small suggestions make sense. If anything, feel free to reach out. Great job and keep going!