Skip to content
OverviewSolutions
2
Comments
4
Szymon prusak
@szymon-99

All comments

  • Szymon prusak•30
    @szymon-99Posted over 3 years ago

    hi great job, only bug i found is when u enter price before qty it doesnt seem to work properly

    0
  • Michal•665
    @mbart13Submitted over 3 years ago

    First of all I wanted to appreciate how well the starter files for this project have been prepared. Responsive images, icons and especially big products.json file containing products data with paths to all images. It must have taken a lot of work, so for that big thanks to FM team (not sure who prepared that, would that be Matt or Em)

    And this was such a great challenge. It's like everything I learned during these 5 months since I joined FM combined into this one big project: modals, custom radios, routing, form validation (checkout form was huge!) and especially creating reusable components. I also tried some completely new things for me like animations, inspired by Tediko and his awesome landing pages I added some on scroll animations on the home page.

    As far as accesibility, new thing for me was 'Skip to content' link and aria-disabled attribute on button instead of 'disabled' for more inclusive disabled form button when cart is empty. For the full list of techniques and tools I used you can check out README.

    One thing I couldn't figure out. In Firefox hero section is included in tabbing order for some reason. I don't see this issue in Chrome. Is that some kind of Firefox bug I'm not aware of, or something wrong with my code?

    If you see anything wrong or that needs to be improved, please drop a comment

    Next.js, Chakra UI, Redux Toolkit, React-Hook-Form, Atomic Design

    4
    Szymon prusak•30
    @szymon-99Posted over 3 years ago

    hi, great job! One thing I would recommend to work on is form fields that require validation. Wrong format message should be displayed only after user finishes typing and the field is actually wrong. Its confusing when user starts typing and immediately there is a message that he's doing something wrong, also I would recommend to disable checkout until you add anything to cart. Besides that well done, also how do you disable scrolling when cart or checkout modals are shown?

    1
  • Jesse•430
    @jesse10930Submitted over 3 years ago

    This project was a total beast! Maybe a bit more than I was prepared for, but I'm fairly happy with how it turned out. It took me about a month to finish, and I really feel I learned a lot along the way. One thing I'm still struggling with is basic file structure, particularly with React and the Context API. I often feel like there's just a big pile of code that becomes hard to sift through when the files get rather lengthy. Any suggestions about how to better organize the code in these files or a best-practice way to place specific blocks of code would be super helpful. Per usual, any other feedback about improving this app or tips I can bring to future projects are welcome, as well.

    Fullstack MERN app using Sass, Hooks and Context API

    3
    Szymon prusak•30
    @szymon-99Posted over 3 years ago

    Great job!

    1
  • Daniele•115
    @LennyManSubmitted over 3 years ago

    Hi everyone, I complete this project to make practice with React. I used a global context for the product and the cart features. The website is fully responsive.

    Any feedback or questions are welcome,

    Thank you,

    Daniele.

    React Js and Styled Component E-commerce website

    1
    Szymon prusak•30
    @szymon-99Posted over 3 years ago

    hi i would recommend spending some more time in css to make this page look more similar to figma project. Also page is not responsive in some places, try to resize browser window so u can check when elements are going too small or too big on which viewport.

    1