Skip to content
OverviewSolutions
4
Comments
1
stv10
@stv10

All comments

  • Hawi Girmachew•250
    @HawigirmachewSubmitted about 2 years ago

    It was my first challenge here in frontend Mentor and it was good. My difficulties in this project were in the responsiveness of my page, can someone review my code and give me feedback?

    Responsive page using CSS FlexBox

    2
    stv10•40
    @stv10Posted about 2 years ago

    Hello Hami! congrats on finishing this challenge.

    Your solution is almost perfecst to me, i'm learning too but here are a few changes i would do.

    1 I don't know if setting body to flex is a good idea, a better choice would be to wrap your content (on this case div 'product'), in a 'container' div and give the flex property to it.

    2 In the smaller screens you forgot to center your divs inside product div, check it out later

    3 Remember using flex means that you will have a father container and childs containers the father is the flex one and it is better if you don't change the size of the father to make the childs smaller. You can quit the flex basis from body and manage the size of product with styles like max-width and max-height and that will allow you to use the align-items property to center your content and not use the padding

    0