Skip to content
OverviewSolutions
10
Comments
4
S Mishra
@sthitaprajna-mishra

All comments

  • Moises Salazar•70
    @rtlsalazarSubmitted about 1 year ago

    Hello 👋, I'm Moisés and this is how I tackled this challenge. I appreciate any feedback on accessibility or how to optimize and simplify my code. The code is made in three different frameworks: React, Svelte and Vue. My goal was to learn how to achieve the same result with different tools.

    🛠️ Built with:

    • Vite
    • SCSS
    • React
    • Svelte
    • Vue

    Responsive landing page with React, Svelte and Vue

    1
    S Mishra•230
    @sthitaprajna-mishraPosted about 1 year ago

    Hi, congratulations on completing this challenge! Your solution looks very good to me and the fact that you used React+Svelte+Vue is very impressive. I have a couple of observations though, hope they'll be helpful -

    1. The footer section is absent in your solution. Was it a design choice?
    2. In the design files we received in this challenge, the 2 inputs for email have custom validation appearing below them in case of false inputs but in the live solution, I see only the default HTML behaviour for email validation.

    I recently completed this same challenge using SASS and vanilla JS, please feel free to critique or comment on it.

    Marked as helpful
    1
  • S Mishra•230
    @sthitaprajna-mishraPosted about 1 year ago

    The responsiveness and design is really good. One thing I noticed is that in the design the container is supposed to be centered both horizontally and vertically but here, it is only horizontally centered. I think we can make the entire body flexbox and then justify and align them in one go.

    0
  • S Mishra•230
    @sthitaprajna-mishraPosted about 1 year ago

    The design is very accurate but the calculation code is breaking and I am getting a lot of "undefined" answers.

    Here are the 2 dates I tried -

    1. 24-05-1999
    2. 24-09-1984

    I am afraid the JS logic needs some update.

    Marked as helpful
    1
  • S Mishra•230
    @sthitaprajna-mishraPosted about 1 year ago

    I really like the new look of the solution although I think the box-shadow of the card could be more blurred out to give a more natural feel. Nevertheless, keep up the good work. I went through the code, it is clean too.

    I joined today and I am planning to attempt challenges every now and then. Feel free to check them out. :)

    Marked as helpful
    1