Skip to content
OverviewSolutions
5
Comments
4
Esteban
@stevedevsign

All comments

  • Jordan•10
    @jordanCrewSubmitted almost 4 years ago

    This is my first project :)

    I really struggled with positioning, any feedback tips or advice anyone could give would be greatly appreciated. I think I have things how I would like it for the defined screen sizes within the README, however any other screen size my background images do drift.

    HTML and SASS solution using media query and flexbox

    1
    Esteban•140
    @stevedevsignPosted almost 4 years ago

    Hi Jordan! you almost made it

    fix this:

    • Background: SCSS > line 26 background-repeat: no-repeat, no-repeat; you have to put 2 values because there are 2 images in your background.

    • Card: Yep I have the same border-radius problem, I use it and then repeat the process for top and bottom... but the solution was very simple

    .card { border-radius: $border-radius; overflow: hidden; } that's it, forget the border-top-right-radius , border-top-left-radius, etc.

    Things I'd recommend:

    • Learn about BEM (Block element modifier) methology, that can help you in differents ways like create reusable components and create your own css framework.

    Great Job!! Keep coding you are really good

    1
  • Luuk•10
    @Blokje93Submitted almost 4 years ago

    Can anyone tell me how I can make the layout change nicely when scaling down the screen size? Currently around 1000px it's not so nice.

    Four card feature section

    1
    Esteban•140
    @stevedevsignPosted almost 4 years ago

    Hi Blokje, good project, very close to the original. add the media queries if you want make a responsive design.

    Just type in the last line (css/scss) @media screen and (max-width: the-resolution) { selector { property: vale; } }

    keep coding

    1
  • Esteban•140
    @stevedevsignPosted almost 4 years ago

    Oh hi again 😃 thank you so much for your time, your feedback is very helpful for me, I'm taking your tips very serious and I'm doing new online courses about front end

    Thank you very much

    1
  • Esteban•140
    @stevedevsignPosted almost 4 years ago

    Hi Victor. The site is really good and very close to the original design also if you would like to improve your skills you can add a smooth transition for a better :hover effect and add media queries.

    Great job!

    1