Skip to content
OverviewSolutions
2
Comments
2
Stephanie Quintana
@stephaniequintana

All comments

  • Stephanie Quintana•50
    @stephaniequintanaPosted almost 3 years ago

    Great job! Your code is very clean. I appreciate the tid-bit on specificity. I haven’t come across it, but hope to remember it if I do :)

    The only suggestion I can make is that rather than hard coding (margins, paddings, font sizes…) in px, consider using a more responsive unit like %, rems or ems - this will help your sites remain responsive. You’ll have less breakpoints and elements to target in your media queries later on.

    One of the best explanations I found for this is by Kevin Powell, https://m.youtube.com/watch?v=_-aDOAMmDHI#menu. He is actually an excellent resource on all things CSS.

    Kudos.

    Marked as helpful
    1
  • Stephanie Quintana•50
    @stephaniequintanaSubmitted almost 3 years ago

    I began this challenge months ago, only returning recently to complete it. That said, there are many classes in the html that I did not use and forget to clean-up before submitting.

    Any feedback or advice will be greatly appreciated.

    Being a true beginner, I especially had difficulties with the javascript part of the code. Namely, in order to open/close each of the sub-menus within the navigation, I wrote individual functions for each of the icons. I am absolutely certain I could have reused the same function by utilizing the event target, but it is lost on me as to how to achieve this. Any direction to this end will be received with great gratitude.

    Positioning of the phones-image in the Infrastructure section proved difficult as it constantly moves as the width of the window increases/decreases. I positioned with a negative margin of the info div, but I expect there is an excellent javascript function for doing this more effectively...I would love to know the best way to handle this situation. I also had difficulty, in this same section, applying the linear gradient. It was cutting off part of the div and I am still at a loss as to why.

    Again, any advice will be greatly appreciated. Thanks in advance!

    Responsive landing page using Flexbox and javascript

    3
    Stephanie Quintana•50
    @stephaniequintanaPosted almost 3 years ago

    Sweet. Thank you! One of my pet peeves in all the tutorials I'm coming across is that they seem to leave out accessibility and will even go so far as to code inaccessible checkboxes to open/close menus...aaaaaaannndd then I forget the alt attributes. Thanks, again - I'll be sure to make it a priority!

    --Stephanie

    0