Skip to content
OverviewSolutions
16
Comments
6
Sammy
@soyed

All comments

  • Sammy•280
    @soyedPosted over 2 years ago

    hi @TejaswiniLabade Great job completing the challenge 🎉!

    Some Feedback:

    • I would recommend resetting the form if there are no errors after a user clicks submit.

    I hope that helps! 😊

    Cheers, Sammy

    Marked as helpful
    1
  • Nairet•10
    @NaiforsythSubmitted over 2 years ago

    Hi!

    I liked the challenge, so I'd like to ask:

    -Is it a good idea to use the CSS grid for this case? Or maybe it's better to use it for something more complex?

    -Is it better to use rem or px or '%' for Responsive?

    Thanks

    QR code component challenge using HTML and Sass

    4
    Sammy•280
    @soyedPosted over 2 years ago

    Hi @Naiforsyth Good job! completing this challenge

    Great Questions by the way

    some feedback:

    1. Yes, CSS Grid can be used to create this component.
      • CSS Grid is used to setup layout for your page or for larger components of your website
      • Flexbox can be used to style the content of your grid items or smaller components
        • An example, The QR Code and the content of the card can be styled using Flexbox
      • I would recommend reading this article
    2. For responsive using rem and % works fine. This is definitely a tricky one because these units have different use cases depending on what you are trying to accomplish.
      • I would recommend reading this article

    I hope that helps! 😊

    Cheers, Sammy

    Marked as helpful
    1
  • Matheus Pergoli•130
    @matheuspergoliSubmitted over 2 years ago

    I've been learning JavaScript for about a week and a half, so I'm still newbie. I love how u can add classes dynamically with JS, so if you have any feedback for me, I'd appreciate :)

    Responsive component with sign-up

    1
    Sammy•280
    @soyedPosted over 2 years ago

    Hi @matheuspergoli Good job!

    Feedback

    • Optional but I would recommend resetting the form if there are no errors after filling all the input fields.

    I hope that helps!! 😊

    Cheers, Sammy

    1
  • Sammy•280
    @soyedPosted over 2 years ago

    Hi @whiplink Good job, your solution looks great!

    Some Feedback:

    • I noticed your images are not displaying, I would recommend fixing it by providing a relative path to your images Relative path in HTML

    I hope this helps! 😊 Cheers, Sammy

    1
  • Sammy•280
    @soyedPosted over 2 years ago

    Thank you 😊 I totally missed that

    0
  • pawel975•190
    @pawel975Submitted about 3 years ago

    I had a problem with implementing same slider in few different variants and places. Would anybody get me advice about duplicating elements but with great control about it's styling in each "instance"? I find writing it again each time from the start not so efficent.

    Ecommerce product page with vanilla JS and pure CSS3

    1
    Sammy•280
    @soyedPosted about 3 years ago

    Hi @pawel975 This looks good! Just a couple of things I would add

    • Add cursor: pointer on the header items
    • Add cursor: pointer on the delete icon in the cart as well
    • one more thing I noticed was you had several ids # attached to your CSS. may I ask why you opted for that?
    • Another thing I noted on Firefox is the page layout looks different. I do not see a modal for the images.
    • Also, remember to make the accessibility changes as well

    But great job overall. Keep grinding! 🤝

    Marked as helpful
    0