All comments

@birb303Submitted about 1 year ago

I’m uncertain about my work and would appreciate a simpler solution for this project. I’m practicing my CSS and hope you can assist me with this. Thank you!

Responsive using CSS Display flex

Thiago Costa de Souza•80

@souzathgPosted about 1 year ago

Hi! Congrats on finishing this challenge!
On your next project, consider using CSS variables so you can reuse values, like this:

:root {
  /* COLORS */
  --primary-dark-cyan: hsl(158, 36%, 37%);
  --primary-cream: hsl(30, 38%, 92%);
  --neutral-dark-blue: hsl(212, 21%, 14%);
  --neutral-grayish-blue: hsl(228, 12%, 48%);
  --neutral-white: hsl(0, 0%, 100%);
  --link-color: hsl(228, 45%, 44%);

  /* TYPOGRAPHY */
  --sans: "Montserrat", sans-serif;
  --serif: "Fraunces", serif;
}

body {
  height: 100vh;
  width: 100vw;
  background-color: var(--primary-cream);
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
}

I took this piece of code from another challenge I completed, but you can get the idea. You can set variables and reuse them all over your style sheet with var(--name).

Hope this feedback was help to you! Keep on coding!

Marked as helpful

David ferreira•40
@davidferreirad1Submitted about 2 years ago
This is my favorite project, I was able to utilize new features I learned recently.

I use the @media feature to make my site responsive for the first time.
Responsive page using @media
2
Thiago Costa de Souza•80
@souzathgPosted about 2 years ago
Hi, David! Congratulations on using @media queries for the first time! The only thing I suggest is to add alternative text in images contained in the "SUVs" div and "luxury" div to help with the accessibility of your page.

I really liked your design! Keep on coding! 🙌🏽
Marked as helpful
0

Thiago Costa de Souza

All comments

Responsive using CSS Display flex

Responsive page using @media