i have a little bit issue with the flexbox property in my main section, that is my "justify-content: space between" to give space between my .main-text and .heroes isn't working in mozilla, but it looks fine in chrome. Any feedback to my problem much appreciated, thanks.
soransh singh
@soransh-singhAll comments
- @stevanusfebrianSubmitted about 2 years ago@soransh-singhPosted about 2 years ago
Great work....
feed back I have:
In mobile and tablet version you left unintentionally a border around the logos... and you can change cursor to pointer when hover over menu button...
I wished I could helped on the problem you asked but I don't know it's solution
0 - @Filippo-BSubmitted almost 3 years ago
I got carried away with this! π I added an animation to the background and the possibility to set your own deadline, if your browser supports the datetime-local input type. Furthermore, the default deadline is the next full moon, and the date comes from an API. In this way the countdown should always work. Let me know what you think! π
@soransh-singhPosted almost 3 years agoyou understood the assignment and slayed it... it look awesome ...
I don't know why but there is a horizontal scroll on my device other than that you have done better than the project in every way...
the extra things you have done make it really cool ... i will try to implement something similar when I will do this project
1 - @excalibur1702Submitted about 3 years ago
- Is there a better alternative to the useMediaQuery hook?
- Is it possible to inherit props between variants?
- Any other general feedback is appreciated!
@soransh-singhPosted about 3 years agohey It looks great... and that drag and drop is really great...
I have a question!! ... How had you setup your repository for frontend-mentor ??? I want to setup my react project better way ... and your repository look well maintain
0 - @anOldChildSubmitted about 3 years ago
Hi, I'm new to using BEM and SCSS. Please help me to check:
- How did I name HTML elements following the BEM naming convention?
- How did I structure my project and the SCSS files and structure code in each SCSS file? Thank you all.
@soransh-singhPosted about 3 years agoBEM means Block Element Modifier In your code Block will be
.pricing-card
then in
.pricing-card
element will be the buttons and text so you will name them.pricing-card__btns .pricing-card__text
one card is different from the other cards so you need modify bg-clr and clr of that card then you can add modifier to it like
.pricing-card--accent
or something.Similarly you can modify btns and text by adding class
card__btns--accent card__text--accent
.you can look this link they have explained better.
0 - @jonaaldasSubmitted about 3 years ago
Did really fast and tried to change the color scheme lol
@soransh-singhPosted about 3 years agohey... you have put the devChallenges link instead of this challenge... btw this challenge looks gooddd...
0 - @TechieStephenSubmitted about 3 years ago
Really enjoyed this challenge. Any pointers much appreciated!! π
@soransh-singhPosted about 3 years agoThis looks great you have done great job.
Just before the breakpoint in desktop design, In footer the social media icons are overlapping the list next to them. Other than that everything is great.
Marked as helpful1 - @peterramirez18Submitted about 3 years ago
I am learning about fronend. This is my first project using html, scss and javascript. Thanks to frontend mentor for these challenges.
@soransh-singhPosted about 3 years agohey I can't see your code... Around 730px to 754px you
slider
h1 look weird. In mobile design nav button is not working.Other than that your design look damn great, everything looks nice and you have done great job. and loved your sticky header on the top. I am going to update that on my challenge.
Marked as helpful0 - @Eugene44-hubSubmitted about 3 years ago
Wow, this was a really nice project which changed my way of writing codes a little. Please i need a feedback about my project, and on what areas i should improve. Thanks.
@soransh-singhPosted about 3 years agoIt looks great you have done great job....
I think you should at to add
margin-right
in classoutput
and alsoborder-radius
in classoutput
andbutton-containers
and you have implemented the calculator logic nicely
it will be more fun if you will add support for calculating negative numbers also if divide .6 by 3(.6/3) you will get a .19999999998 ... you can round off number to certain digits so it doesn't show too much 9's
Marked as helpful1 - @H0bG0blin9gSubmitted about 3 years ago
I am abit confused with the accessibility issues I have regarding "landmarks". Im not entirely sure what they are, and even after some googling I have no idea how to solve this. Granted I have made use of divs instead of the semantic names like article (I never really got around to grasping the semantic names and have been using divs everywhere), etc, so im inclined to think the issue lies there, but im not sure what to do to solve this. Any help regarding the solution as well as the importance of this would mean a lot!
Otherwise, this is my first frontend mentor challenge. This took longer than I was anticipating. Im sure there are simpler ways to achieve what I did and probably with less code and more elegence, however I am surprised at how much of a learning experience this has been and look forward to more challenges.
I realised that the order in which you tackle the challenge can go a long way in maintaining your sanity - too much jumping back and forth made it confusing for me to fix some css issues, so in the end I started again and tried do things in a logical order as opposed to randomly targeting elements on the design.
Looking forward to some feedback from the community as well as seeing how everyone else has come up with their solutions!
@soransh-singhPosted about 3 years agoIt looks great ... You have done great job ... Kudos to you for completing your first challenge
1 - @caldwelljt2Submitted about 3 years ago
This is the first time I've really tried to do my own thing at all in code. I got considerable help from a couple people in the Slack channel because I am trying to learn how people think through their design and keep parts usable for other implementations. It probably shows in my code because I'm doing a few things that aren't optimized (importing) that I know I could avoid.
Things that don't work right and I dont know how to fix or need help with:
- Mobile version overlaps on left and messes up background when below 450px.
- In general I don't know how to keep the entire thing relative using vh/rem (or if that's even SoP)
- Resizing through 784px isn't smooth (I had it set to 700px, not sure how the final version has 784px, but i'm submitting it anyways because I was just guessing that 700 was just under likely 1024x768 and far enough over mobile that it would be rare to see resize happen organically).
What I know I did wrong and don't care for now (i'll tackle it in the future):
- Variable usage/labeling
- Any usage of Grid (I simply haven't learned it but will in the next week)
- Left various code bits in that aren't needed.
In short, I stopped my progress on learning Vue because I realized I had rather poor understanding of the DOM/html in general. I've done a lot more with back end and had to similarly stop along that progress to better understand core concepts.
Really, ANY feedback is welcome, but my preference is to tackle glaring errors or things that are "bad habits" up front.
@soransh-singhPosted about 3 years agoIt looks good... it's your first submission congrats... you have done a great job
0 - @caldwelljt2Submitted about 3 years ago
This is the first time I've really tried to do my own thing at all in code. I got considerable help from a couple people in the Slack channel because I am trying to learn how people think through their design and keep parts usable for other implementations. It probably shows in my code because I'm doing a few things that aren't optimized (importing) that I know I could avoid.
Things that don't work right and I dont know how to fix or need help with:
- Mobile version overlaps on left and messes up background when below 450px.
- In general I don't know how to keep the entire thing relative using vh/rem (or if that's even SoP)
- Resizing through 784px isn't smooth (I had it set to 700px, not sure how the final version has 784px, but i'm submitting it anyways because I was just guessing that 700 was just under likely 1024x768 and far enough over mobile that it would be rare to see resize happen organically).
What I know I did wrong and don't care for now (i'll tackle it in the future):
- Variable usage/labeling
- Any usage of Grid (I simply haven't learned it but will in the next week)
- Left various code bits in that aren't needed.
In short, I stopped my progress on learning Vue because I realized I had rather poor understanding of the DOM/html in general. I've done a lot more with back end and had to similarly stop along that progress to better understand core concepts.
Really, ANY feedback is welcome, but my preference is to tackle glaring errors or things that are "bad habits" up front.
@soransh-singhPosted about 3 years ago-
In card.css .container-outside, Instead of setting width:450px set max-width: 450px and add some margin.
-
If you want to make it relative like when screen size increase width of card also increase you can use percentage(%) or you can use Vw.
Marked as helpful0 - @ShelcySubmitted about 3 years ago
Hi Frontend-mentor community π!
I solved this challenge using only css, if you have a recommendation or any comments, I will be grateful.
See you, best wishesπΌ.
@soransh-singhPosted about 3 years agoGreattt work ... I have never got those background images correct (neverrr.... I hold grudges toward those background images)
1