All comments

• 

  Angela•30

  @adyrmishiSubmitted over 1 year ago

  

  QR code

  1

  30
  

  sophie.•150

  @sophie-mc-devPosted over 1 year ago

  Hi!

  Your solution looks great! However, I noticed you forgot to apply a border-radius to the qr code image. Maybe a border-radius of 10xp?

  Keep up the good work!

  Marked as helpful

  0
• 

  Miguel Willians•10

  @miguel-williansSubmitted over 1 year ago

  I altered the background because i wasn't sure how to make the original, but I think the final result isn't bad at all.

  

  QR Code page using basic HTML and CSS (mobile responsive)

  2

  30
  

  sophie.•150

  @sophie-mc-devPosted over 1 year ago

  In the future, check the style-guide.md file to learn what colors, fonts, font-sizes, etc. the challenge requires! To make the styles more accessible, I would reccomend creating variables, at the top of the CSS file, that represent the colors & fonts needed for the challenge.

  In this case, you could add to your CSS file:

  --light-grey: hsl(212, 45%, 89%);
  
  body{
  font-family: 'Outfit';
  background-color: var(--light-grey);
  }
  

  0

  This comment has received 2 repliesShow
• 

  Billal Patel•50

  @BillalPatelSubmitted over 1 year ago

  I wonder if the structure of my CSS is correct?

  

  QR Code Component w/ HTML & CSS

  2

  60
  

  sophie.•150

  @sophie-mc-devPosted over 1 year ago

  Your CSS structure looks great! Regarding your HTML code, even though your design is simple and straightforward, you can further improve it by using more semantic HTML elements. For example, instead of using a generic <section> for the QR code and description, you can use specific semantic elements such as <figure> and <figcaption> to enhance the meaning and structure of your content.

  Marked as helpful

  1

  This comment has received 1 replyShow