All comments

• 

  Alejandro• 60

  @alemarr

  Submitted 8 months ago

  • Would you improve something in the markdown? If so, what?
  • What would you do different in the main.css file?
  • Do you think I should've focused on going mobile-first and using media queries for the screen sizes given in the challenge? (you can find them in style-guide.md)

  

  Blog Preview Card

  1

  20

  

  Peter• 20

  @skipperr254

  Posted 14 days ago

  Hi there Alejandro, good job on completing this project. You did try to make it look as close as possible to the design.

  It looks like you pasted the wrong GitHub link so I couldn't access your code. I think you did a good job on the card. May be you could have made it a little bit taller to match the given reference.

  Anyway, congratulations on your card!

  0
• 

  khushi-vish• 10

  @khushi-vish

  Submitted about 1 month ago

  

  basic card using html, css

  2

  20

  

  Peter• 20

  @skipperr254

  Posted about 1 month ago

  Hi there Khushi, good job on the project.

  • I noticed you used the with property in the body element and set it to 100%. In my experience and advice from experts, it's usually not necessary and everything works if it's omitted completely. It also adds the scroll effect even on a page that it is not necessary at all.

  • Also, didn't the justify-content: center; work or why did you comment it out? I think it would have centered the card element. If you were being adventurous then its okay. Just wanted to know.

  • I missed the background color/colour of the body too, lol! Not sure where I went wrong but will look at it later.

  • Also, when I submitted my solution, I was pushed to correct on accessibility by using HTML5 landmarks like header, main, footer, etc.

  1