KhamriOussama• 80
@KhamriOussama
Submitted
P
simgeduru
@simgeduru
All comments
Hello,
I have a few suggestions to improve the code:
-There is a white border around the buttons, which should be removed. -It seems that the color in the description class might be incorrect. -Using rem units for width and height values might be more appropriate instead of px. -This will allow the system to automatically adjust based on the pixel value. Instead of writing a div with a main class, it would be more semantically correct to use the main tag.
I hope you find these suggestions helpful.
Marked as helpful
0- kleschmabilla• 20
@franzbackhaus3008
Submitted
What are you most proud of, and what would you do differently next time?
I am quite happy with the solution even though it is not quite perfect
What challenges did you encounter, and how did you overcome them?
I was first struggling with the html structure of the div elements, but after some consideration i think i got it down.
What specific areas of your project would you like help with?
I dont know if my font implementation is correct, and if there are ways to improve my html structure
I have heard that it is not correct to give a width height value in imgs, and doing so leads to distortions in responsive designs. that's my only advice
0
