Skip to content
OverviewSolutions
4
Comments
3
Shimul
@shimul0022

All comments

  • Shimul•40
    @shimul0022Posted about 2 years ago

    looks very nice so congratulations. but it's not showing on the screenshot section. and it would be a little better if you placed the footer i.e your name and frontend mentor link a little above or just below the card.

    being that said, your whole design was fantastic

    1
  • Shimul•40
    @shimul0022Posted over 2 years ago

    So @eliepoupoue, there's a lot going on in your design and code. but to answer your question im gonna skip the other ones.

    You have to add media queries, it looks something like this . . .

    @media screen and (max-width: 375px) { your modified css for mobile friendliness goes here }

    I will recommend you to watch this Web dev simplified video or a bit more advance option would be this Dave Gray Video

    Happy coding! and if you want to know any other sort of solution then we can connect

    0
  • Rodrigo León•40
    @ReyesRo10Submitted over 2 years ago

    Hello community this is my first challenge in this great plattform. Now I want to start using semantic html because I learned using only div tags for everything, so I have a question:

    It would be better use the article tag? or using main tag is ok?

    All feedback is well recived. Have a great day!

    QR Component

    2
    Shimul•40
    @shimul0022Posted over 2 years ago

    @ReyesRo10 hey, first of all congratulation for the completion of your first challenge.🎉

    now, you have used semantic elements in the correct way in this challenge. You can't really use more than one main element in a html file. but you can use multiple articles. and being that said, articles always go inside the main element. and usually used for blog post or wrapping a lot of written content.

    So, if you want to divide your body for more semanticity, then at first add header, main and footer. then you can put things in the main element into different sections or articles.

    and btw, you should delete the README.md file that's with the challenge files and rename the README-template.md file to README.md. then modify the content inside the new README.md file. all the instruction will be written there to guide you.

    Happy Coding!

    0