Skip to content
OverviewSolutions
4
Comments
6
Sizwe Mashele
@seezmashele

All comments

  • Sizwe Mashele•170
    @seezmashelePosted about 1 year ago

    Hi Bruno, I like your app but I don't know how to get past the phone number check

    Can you add a tip to help others know what's wrong there.

    Great job on completing this challenge 😀

    0
  • Sizwe Mashele•170
    @seezmashelePosted about 1 year ago

    Hey Krzysztof, congrats on completing this challenge😀

    I noticed the map and ip addresses keep on changing after searching. My guess is that the useEffect in "SearchBar.jsx" where you use fetchMap update again and again because useEffect runs when it's dependencies change.

    useEffect(() => { fetchMap(); }, [input, fetchMap]);

    I hope that helps.

    The rest of the app is really well done. Good luck with the other challenges!

    0
  • Sizwe Mashele•170
    @seezmashelePosted over 1 year ago

    Hi Cheis 👋

    Great job on recreating this calculator project!

    I noticed a bit of the maths functionality was missing and thought a library like *mathjs * could be useful. It can handle your app's calculations e.g. "1 + 2 x 3" allowing you to focus on the user's inputs.

    This project has some challenging bits so I hope it helps 😃

    Happy coding!

    Marked as helpful
    0
  • Sizwe Mashele•170
    @seezmashelePosted over 1 year ago

    Hey Siddarth, great job on completing this complex challenge😃

    The way you've used animations really made the form exciting to fill out!

    A few tips you can consider to make things easier for users:

    • Saving what users type or select when moving back and forward
    • Selecting an addon by clicking the whole card instead of the small checkbox
    • Allowing + in the phone number check

    I hope this feedback can help you in future projects as well🤓 Happy coding!

    1
  • Sizwe Mashele•170
    @seezmashelePosted over 1 year ago

    Hi Peikra, let me dive right in with the advices😀

    Great job on matching the design and using specific HTML tags for headings and text etc.

    Looking at your code, I recommend using a formatter like prettier to tidy your code, making it easier to see how elements are nested.

    The top of the card doesnt fit in the page when the height is thin, it's good to practice (and it's fun) to squash the width and height to catch these sort of things.

    I hope my advices serve you well 😅

    Marked as helpful
    0
  • Sizwe Mashele•170
    @seezmashelePosted over 1 year ago

    Hi Celi 👋

    Great job on your first Frontend challenge! It's awesome that your code is neat and uses accurate HTML tags for text and headings etc.

    I noticed the position of the card moves up and down based on the width of the page which some users might not expect, but hey, we're allowed to have a little fun here 😄.

    You could add a shadow to the card as well if you want to match the design a little closer.

    Other than that, it's big thumbs ups for diving in 🚀

    Marked as helpful
    1