Skip to content
OverviewSolutions
12
Comments
4
Vijay Choudhary
@scriptyvijay

All comments

  • Jeremy•220
    @JMwiraSubmitted 10 months ago

    Hey fam, I hope you find time to checkout my recently completed challenge and be kind enough to comment on how I can make it better. its the project-tracking-intro-component

    project-tracking-intro-component

    1
    Vijay Choudhary•200
    @scriptyvijayPosted 10 months ago

    Hi Jeremy,

    You can fix some minor issues as mentioned in design-

    1. There's some issues with font weight
    2. Fix Fonts sizes of menu bar
    3. Main title is not aligned center
    4. Both images phone and laptop looking bigger
    5. Always check style guide for example your button background color is not same as design.
    Marked as helpful
    0
  • Vijay Choudhary•200
    @scriptyvijayPosted 10 months ago

    Well You've created good no doubt, But you need to improve padding and font size.

    As you can see at qr image above there's some negative space.

    And according to design your font looks too bold.(Font weight) to know more about font weight check style guide.

    You can also fix some negative spaces in your design also.

    Marked as helpful
    0
  • Vijay Choudhary•200
    @scriptyvijayPosted 10 months ago

    Well you built it very good but i can suggest you some points to improve your design skills -

    1. Perfume Word need word spacing
    2. Your main div isn't in center
    3. Need some padding in bottom after pricing
    4. Image is streching you can use object fit property to fix it.
    5. Description words are getting some spaces which not looking good

    Hopefully this helps you.

    Marked as helpful
    0
  • Vijay Choudhary•200
    @scriptyvijayPosted over 1 year ago

    As i can see -

    Your github is showing there's no HTML or CSS files. You just have a simple readme file. To complete the solution you need to commit and push your html and css files to github and then you can submit the solution.

    For this time your solution is can't be acceptable because of there's no solution available due to no files. Push your files to github and resubmit the challenge.

    Marked as helpful
    0