Skip to content
OverviewSolutions
5
Comments
2
El-Sayed A. Naser
@sayednaser

All comments

  • El-Sayed A. Naser•90
    @sayednaserPosted almost 3 years ago

    Keep it up :) Regarding your question, for space measurements you can use any editor like paint or PS. For typography, at first you could use your eye and then tune the values using any tool overlaying the image over your page with opacity. One example is "PerfectPixel".

    P.S.: This is the tl;dr of my reply on your comment in my solution :)).

    Marked as helpful
    0
  • El-Sayed A. Naser•90
    @sayednaserPosted almost 3 years ago

    Great work <3

    I've noticed one issue. You are using <p> tag for all the text. While it visually causes no problem. It causes accessibility issues (e.g for screen readers). The title should be a heading element (specifically <h1>). Don't be confused by the default styling of it, you can and should overwrite its style as you want. Also notice you should use <h1> element once in a page. The next levels are <h2> <h3>... Also, this should get rid of the accessibility issue in the report.

    Keep it up :)

    Marked as helpful
    0