Skip to content
OverviewSolutions
4
Comments
4
Savannah Acevedo
@savvycolleen

All comments

  • Savannah Acevedo•80
    @savvycolleenPosted 4 months ago

    Loving the scroll effect!! So cool. Everything looks really good. There are no complaints with your outcome! The only constructive feedback I can think to give would be possibly breaking up your RecipePage.js into components for readability. Cheers to you!

    Marked as helpful
    1
  • Savannah Acevedo•80
    @savvycolleenPosted 4 months ago

    Good afternoon! Thanks for sharing your solution--the card looks really great! In looking at your styling, I love how you used calc for the width of your container. That is a great idea that added to my thinking! Generally speaking, your design turned out bigger than the original, so sizing some things down like the size of the image, h1, and the margin tops of your social links could help make it look even closer to the original (if you are trying for a more precise solution!). Hats off to you!

    0
  • Savannah Acevedo•80
    @savvycolleenPosted 4 months ago

    You card looks great! I love that you used variables for your colors in CSS. I always intend to do that and then skip that step. It's a great habit to get into it! I also like how you used "fit-content" for the yellow background on "Learning"--that is probably more simple than what I did in my solution. The only thing I noticed for the html is putting your divs in something more semantic like "section" or "main." I know it feels weird when there is not a full layout, but it seems like a good practice to follow when possible! Cheers on your work!

    0
  • Savannah Acevedo•80
    @savvycolleenPosted 5 months ago

    I love that you centered this by using flex on the body! A creative solution and great idea. Hats off to you!

    1