devkhrmnturk• 60
@devkhrmnturk
Submitted
Saul Gustavo A. S.
@saul-gustavo
All comments
- Saul Gustavo A. S.• 530
@saul-gustavo
Posted
Hello, I saw your html and css code and it looks very good, it is understandable when reading it.
Good job!
0 - Enrique Farias• 80
@EnrikeOmarFarias
Submitted
What are you most proud of, and what would you do differently next time?
Hola! ahora si pude subir el archivo para que se vea correctamente en sitio, disculpen
What challenges did you encounter, and how did you overcome them?
Mi desafío fue centrar los elementos y que cambio la imagen de acuerdo a la pantalla en la que se este viendo la pagina
What specific areas of your project would you like help with?
Centrar los elementos
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hola vi tu código y se entiende lo que querías hacer, te sugiero que pongas los media querys en el mismo archivo css, así será más fácil de leer tu código, También te recomiendo que para centrar adecuadamente un container, en este caso el main principal, uses lo siguiente:
.contenedor-principal { display: flex; justify-content: center; align-content: center; width: 100%; min-height: 100vh; }Esto hará que el main se centre de manera adecuada, y en el .contenedor-secundario, puedes usar lo siguiente:
.contenedor-secundario { width: 100%; max-width: 500px; }Esto hará que el contenedor abarque el 100% pero que no pase de los 500px, puedes usar más pixeles para darle la forma adecuada como esta en la imagen del diseño.
También te recomiendo mucho que veas otras soluciones dentro de la plataforma de frontendmentor para que te des una idea de como hacer los diferentes desafios.
¡Happy Coding!
Marked as helpful
0 - j124klo• 40
@j124klo
Submitted
What are you most proud of, and what would you do differently next time?
I made good looking side. I even added this small blinking animation. Next time i would try to make better text (when you open the page on a phopne, h1 gets folded into next line instead of decreasing font size to ajust).
What challenges did you encounter, and how did you overcome them?
I had to learn how to use "@font-face".
What specific areas of your project would you like help with?
How can i make my code look more professional.
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hello, I saw your html and css code and it is clear what you wanted to do, I recommend using the following:
*, *::before ,*::after { margin: 0; padding: 0; box-sizing: border-box; }this way you will eliminate all the margins and padding by default, in the animation section you can only put a hover effect on the text, like this:
text:hover {color: yellow;}1 - Giovanna Garavaglia• 100
@giovannagaravaglia
Submitted
What challenges did you encounter, and how did you overcome them?
To be honest, it was my first time coding javascript. The code is not perfect and I wanna do this challenge again next month and do better
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hello, I saw your HTML and CSS code, and it’s clear what you did. I checked the JS code and noticed you use a lot of functions and variables. I highly recommend you check out other solutions here on the Frontend Mentor platform, so you can get an idea of how to better structure your code and follow good practices. In this challenge, I used an addEventListener to submit the email from the form. You can take a look at my solution to get an idea of how to implement the code.
Happy coding!!
0 - Enrique Farias• 80
@EnrikeOmarFarias
Submitted
What are you most proud of, and what would you do differently next time?
Hola! se que me falta mucho por aprender para optimizar el sitio pero queria compartir el grado de avance que voy teniendo, gracias
What challenges did you encounter, and how did you overcome them?
Al principio me costo todo pero como veran me falta ajustar para que quede centrado el qr
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hola, vi tu código y se entiende lo que querías hacer, pero te recomiendo que para centrar este único elemento del proyecto uses flexbox en el body, con un min-height de 100vh y con eso se pondrá en el centro. Tu puedes, practica constantemente, ve otras soluciones aquí en la plataforma, te darás una idea de como puedes mejorar cuando hagas otro desafió.
¡Mucha suerte, Happy Code!
0 - RogerTito455• 160
@RogerTito455
Submitted
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hello, I saw your CSS code, and I understand what you wanted to do, I advise you to use grid areas, to do this challenge, with this property you can specify the order and position of each card, good job,
Marked as helpful
0 - Taio725• 10
@Taio725
Submitted
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hello, I saw your HTML code, I recommend using semantic HTML, with section, article, main tags, this way it will give a better view to your project.
In your CSS code you can use Flexbox to center the container, so it will have a better view.
Keep it up
1 - waithakan• 10
@waithakan
Submitted
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hello, I saw your HTML code, it is easy to understand, but I recommend that you use semantic HTML, with section, main, article tags, it will make your code easier to understand.
In the CSS styles of the image and the main div, you can give a max-width so that it has a max width. You can do it my friend, keep practicing
0 - M.A.B• 80
@MohamedAbdelBAQIMo
Submitted
What are you most proud of, and what would you do differently next time?
Visit Site to See this isnt real
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hello, I saw your HTML tags and it is understandable, but I recommend that you use a semantic tag structure, that way it will look better.
In your CSS code, you use many margin properties, you can center the container with Flexbox directly from the body tag, so you can have centered content. I also recommend using the colors indicated in the styles guide, so you can have a better design in your project.
You can do it!!
Marked as helpful
1 - Danish• 80
@Danish030
Submitted
Saul Gustavo A. S.• 530@saul-gustavo
Posted
Hello, I saw your code and there are some things you can take into account to improve your project, in the body, you can use min-height 100vh and center the container with flexbox.
Inside the container you can use the padding property to give more padding to the content, this way you would avoid using the height and width property. You can do it, keep it up.
I would also recommend using semantic html, it will make your code look clean and easy to understand.
Marked as helpful
0
