Hola este es el tercer desafío que hago, cualquier crítica constructiva es bienvenida. Hice todo con CSS, lo único que no logre es hacer desaparecer el menú mobile, cuando se le da click a un enlace. cualquier sugerencia o ayuda con eso es bienvenida.
Sarah Wylie
@sarahwylieAll comments
- @nico-abreuSubmitted about 2 years ago@sarahwyliePosted about 2 years ago
This looks great, Nicolas! When I clicked the links I didn't expect to go to a new page, but perhaps they could reference different sections of the layout rather than sending me back to the top each time? For example, the "Services" button at the bottom could take the user to the "Graphic Design" section of the page rather than just using the "#" reference. The links at the bottom are also open for fun - use these to reference your personal sites!
I noticed that your images have empty <alt> references. Be sure to use these to improve accessibility within your site!
Great work!
Marked as helpful1 - @correlucasSubmitted over 2 years ago
👾 Hello, Frontend Mentor coding community. This is my solution for the QR Code Component.
Making this challenge again was something really amazing for me, first because going back through my past challenges I was able to fix some issues and clean my code and then because was my first time using JS (yes I'm a newbie) 😂
I added some features:
- 🎨 Dark and Light mode button
- 👾 Custom QR Code image
- 🧚♂️ A little bit of color customization
- 👨💻 Custom image hover state
I'll be happy to hear any feedback and advice!
@sarahwyliePosted about 2 years agoI love this, Lucas! How fun! Makes me wish I had spent more time having fun with mine, but alas I was too eager to dive into more new projects!
My only suggestion is for your <h1> line of code. It changes color, but that is behavior typical of a button or link. Perhaps change this into a link and add a cursor pointer?
Well done!
Marked as helpful0