Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @DavidIrvine-TW

    Submitted

    My 2nd Frontend Mentor challenge.

    Like the 1st challenge, I enjoyed coding this one also. It was a little more challenging than the 1st one (QR code) due to the responsive design.

    Any feedback welcome!

    Happy coding! :)

    @sarahsoaressilva

    Posted

    Hello, David!

    Great job! Just one thing that I saw, when using devices with 375px width (IPhone SE if you use inspect elements on the browser), the footer text overlap the card. I believe that is because "position: absolute" and "bottom: 0".

    If you want the text to stay in the end of the card, one solution is that you can use "padding: 3rem" and remove bottom and position properties. But it's just a suggestion. I hope this can help.

    Happy Coding!

    0
  • @sarahsoaressilva

    Posted

    Hey! Good job!

    I have an advice. You can use utility classes or custom props to reuse some part of your CSS code, like the "height: 500px" of img and #text-div or the "margin" values. This will make your CSS even better.

    I will also send you a link of a video of Kevin Powell, his channel is amazing. Hope it can help you.

    Link: Get more out of custom properties

    Good coding!

    0