Give feedbacks βΊοΈ
shiva santosh jana
@santu369All comments
- @alexis-ferreiraSubmitted over 3 years ago@santu369Posted over 3 years ago
Hi Alexis,
Good job on finishing the challenge πͺ
- The headshot image is changing on button click, but the quote section isn't. Maybe you missed it. Please check once.
0 - @khalisabrahmanSubmitted over 3 years ago
I can't get the picture in the mobile layout right. There's a line there. Any suggestion?
@santu369Posted over 3 years agoHi Khalis,
Good job on finishing this challenge πͺ
-
Try setting
display: block
on theimg
element. I faced the same issue and this trick fixed it. -
I am viewing this on mobile and I can see the top section of the image getting cropped. You can check on this once.
Thanks, Shiva
0 -
- @vatsalsinghkvSubmitted over 3 years ago
I was facing some problems.
picture::before { content: ''; position: absolute; top: 0; left: 0; background: var(--soft-violet); mix-blend-mode: multiply; width: 100%; height: 446px; }
In this ::before selector, initially i made height = 100%, But I was getting image size (height) less than the picture tag, I couldn't figure out why, so I made height of the ::before equal to the height of the image.
Can anyone help me why I was having that height of image & picture tag problem?
@santu369Posted over 3 years agoHi Vatsal,
By default,
img
element is displayed as inline-block. You can change it todisplay: block
and addheight: 100%
orright: 0; bottom: 0;
topicture::before
, this should solve the problem you were facing.Good job on finishing the challenge π
1 - @mansi05041Submitted over 3 years ago
In mobile design the image is not fitting on the screen ( width ). Please comment on responsive part .
@santu369Posted over 3 years agoHi @mansi, There is one more image provided with the design files - image-header-mobile.jpg, you can change the image to this one in mobile view. I checked the code and didn't find this being used. Hope this helps.
1