Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Fernando• 80

    @fernandosotosanchez

    Submitted

    Para ir entendiendo CSS que tal lo hice ?

    Codigo QR

    1

    Santiago• 140

    @santiagosg

    Posted

    Para resolver los problemas de accesibilidad que te marca la página: Debes de usar un título de primer nivel ( <h1> </h1> ). Échale un ojo a las etiquetas nativas de html5 como header, footer etc. para este caso puedes usar la etiqueta "main".

    Como recomendación personal: Pon más detalle en los elementos (el tamaño, el color, el border-radius), te recomiendo usar un programa de diseño para que tomes nota de estas cosas, por ejemplo illustrator, yo personalmente uso figma. Por el código como tal, vas bien, sigue así, a medida que sigas haciendo irás descubriendo nuevas cosas. Veo que estás usando nomenclatura Bem, esto está muy bien.

    Marked as helpful

    0
  • Santiago• 140

    @santiagosg

    Posted

    On the main page I don't see the title like in the screenshot of this page, if anyone has any feedback on this or the treatment of the text to make it more like the design, it's totally welcome.

    0
  • Santiago• 140

    @santiagosg

    Posted

    Hi Anna

    I think you use too much the div for elements that don't need it, like in the plan (the image and the plan-change).

    You are using a button to "proceed payment" and "cancel order", that's good and its ok, but remember to add a "cursor: pointer;"

    Try to organize your documents, like all the images in the images folder, and maybe your style.css under a css folder too.

    You are doing great, keep moving.

    P.D. I liked your way to show the screenshot in GitHub

    Marked as helpful

    0