sankalp kumar
@sankalp475All comments
- @KotaAneeshReddySubmitted 11 months ago@sankalp475Posted 11 months ago
Hi, Excellent project👏.
I have some simple suggestion you might find interesting. I noticed that you have
<p>Published 21 Dec 2023</p>
in your code When a screen reader is reading the above it will pronounce 21 Dec 2023 as it is. This should be wrapped in<time datetime="2023-12-21">21 Dec 2023</time>
This is machine readable therefore it is more accessible for user's with visual impairment and it is also accessible by calender such a google calender. To find out more about the time tag check out this articleOther than that your project is EXCELLENT 🤩
Happy coding 🙃
0 - @ArnaudM1983Submitted 11 months ago@sankalp475Posted 11 months ago
Hi, Excellent project👏.
I have some simple suggestion you might find interesting. I noticed that you have
<p>Published 21 Dec 2023</p>
in your code When a screen reader is reading the above it will pronounce 21 Dec 2023 as it is. This should be wrapped in<time datetime="2023-12-21">21 Dec 2023</time>
This is machine readable therefore it is more accessible for user's with visual impairment and it is also accessible by calender such a google calender. To find out more about the time tag check out this articleOther than that your project is EXCELLENT 🤩
Happy coding 🙃
0 - @N0XUS0Submitted 11 months ago@sankalp475Posted 11 months ago
bro your challenge is Different and your solution is Different
1 - @btjlSubmitted 11 months ago
- How would you rate the semantic tagging of my solution?
- Any comments on the way I handled the image's height and scaling?
@sankalp475Posted 11 months agoHi, Excellent project👏.
I have some simple suggestion you might find interesting. I noticed that you have
<p>Published 21 Dec 2023</p>
in your code When a screen reader is reading the above it will pronounce 21 Dec 2023 as it is. This should be wrapped in<time datetime="2023-12-21">21 Dec 2023</time>
This is machine readable therefore it is more accessible for user's with visual impairment and it is also accessible by calender such a google calender. To find out more about the time tag check out this articleOther than that your project is EXCELLENT 🤩
Happy coding 🙃
Marked as helpful0 - @DanidivSubmitted 11 months ago@sankalp475Posted 11 months ago
Hi, Excellent project👏.
I have some simple suggestion you might find interesting. I noticed that you have
<p>Published 21 Dec 2023</p>
in your code When a screen reader is reading the above it will pronounce 21 Dec 2023 as it is. This should be wrapped in<time datetime="2023-12-21">21 Dec 2023</time>
This is machine readable therefore it is more accessible for user's with visual impairment and it is also accessible by calender such a google calender. To find out more about the time tag check out this articleOther than that your project is EXCELLENT 🤩
Happy coding 🙃
0 - @git-riteshSubmitted 11 months ago
Hi there 👋, I’m Spirit, and this is my solution for this challenge.
✨ Features:
- Achieved 100% in Lighthouse score for performance 🚀, accessibility, best practices.
🛠️ Built With :
- Mobile First CSS. 🎨
- BEM Convention
Question:
- How to achieve pixel perfect design which matches approx. 100% with the Challenge Design ?
- Any Best Practices which I should have followed in this challenge ?
Any feedback is appreciated. Thank You : )
@sankalp475Posted 11 months agoHi, Excellent project👏.
I have some simple suggestion you might find interesting. I noticed that you have
<p>Published 21 Dec 2023</p>
in your code When a screen reader is reading the above it will pronounce 21 Dec 2023 as it is. This should be wrapped in<time datetime="2023-12-21">21 Dec 2023</time>
This is machine readable therefore it is more accessible for user's with visual impairment and it is also accessible by calender such a google calender. To find out more about the time tag check out this articleOther than that your project is EXCELLENT 🤩
Happy coding 🙃
Marked as helpful0 - @git-riteshSubmitted 11 months ago
Hi there 👋, I’m Spirit, and this is my solution for this challenge.
✨ Features:
- Achieved **100% in Lighthouse score for performance 🚀, accessibility, best practices.
🛠️ Built With:
- Mobile First CSS. 🎨
Any feedback is appreciated.
Thank You : )
@sankalp475Posted 11 months agoHi, Excellent project👏.
I have some simple suggestion you might find interesting. I noticed that you have <p>Published 21 Dec 2023</p> in your code When a screen reader is reading the above it will pronounce 21 Dec 2023 as it is. This should be wrapped in <time datetime="2023-12-21">21 Dec 2023</time> This is machine readable therefore it is more accessible for user's with visual impairment and it is also accessible by calender such a google calender. To find out more about the time tag check out this article
Other than that your project is EXCELLENT 🤩
Happy coding 🙃
0 - @git-riteshSubmitted 11 months ago
Hi there 👋, I’m Spirit and this is my solution for this challenge. 🚀 Difficulties :
- Adding Multiple SVGs to the background was quite difficult for me.
My approach :
-
I tried to add SVGs in the html and then give it a
position
andz-index
to add both the top & bottom SVGs but it didn't worked properly because when i stretched the page to check its responsiveness it failed the SVGs dislocated from their prior position. -
Then I seeked help from my community & got to know about specifying Multiple Backgrounds in CSS Ruleset and used
background-image
property in the body tag and separated both SVGs with commas and specify the properties related to backgrounds using the same. Then it got fixed.
I am still unsure of the thing that is this the only best approach to add multiple backgrounds or SVGs in the background ?
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. 😊✌️
@sankalp475Posted 11 months agoSo beautiful, so elegant just looking like wow
Marked as helpful2