@morrryyyyy
Samuel Adu
@samuel-aduAll comments
- @samuel-adu
Excellent work on bringing the design to life, absolutely pixel perfect.
- @Dadv-a11yWhat challenges did you encounter, and how did you overcome them?
Thé challenge was to use and understand state i overcome it with youtube tutorial
@samuel-aduThis is an excellent solution, its neat and super close to the design. I love how the confirmed order list scrolls in confirmation modal and keeping the modal in place.
However I have a few suggestions for you to look at
-
the grid layout you have in large screen size is what you should have in medium screens. Looking at your code if you change
md:grid-cols-2tomd:grid-cols-3this will fix it. -
the addToCart button should add the item to cart according to the project brief, you should look into that.
Even with all of this, your solution is excellent and I love your implementation of the state management.
Marked as helpful -
- P@MathiasHun1What are you most proud of, and what would you do differently next time?
The layout was so hard to implement for all screen sizes. At least for me :P
I feel the css could be simplified, I did some repetitive code defining the grid-areas for the pages, and things related to that.
I just learned how creative utility classes can be, I'm very bad at it but did my first steps
What challenges did you encounter, and how did you overcome them?Managing the css, somewhat modularized it with sass partials, but it's far from perfect
@samuel-aduExcellent work
- @collins-aiWhat are you most proud of, and what would you do differently next time?
I'm glad I could successfully make use of tailwind css to style the webpage easier and faster. The javascript which i applied is also something I'm proud of.
What challenges did you encounter, and how did you overcome them?Since it's my first time to use tailwiind, it took a lot of time for me to finish the challenge. I also had a hard time deploying it with github pages, but it's all done now.
What specific areas of your project would you like help with?Nothing for now.
@samuel-aduExcellent work, my only suggestion is that you improve the mobile responsiveness. The feature images and faq on mobile doesn't meet the design requirement. Also great work with the email validation.
Marked as helpful - P@fsahinbas@samuel-adu
Another excellent work from you, could you also make it responsive.
Marked as helpful - P@fsahinbas@samuel-adu
Good work Fatih!
I have a few suggestions to improve the design, especially the about and creation section.
- your main should wrap the image-interactive and the creations sections.
- the see all button in mobile should be after the creations card
- in desktop you can position the see all button to top right relative to the creation section
This should fix the creation section flowing out of screen in both mobile and desktop view.
Overall this a very solid work and its clean too.
- @vicymicheal@samuel-adu
Good work, the solution very close to the design. In mobile view the card is touching the body of the device, if you could add paddings to both side of the container this will work.
Marked as helpful - P@fsahinbas@samuel-adu
Excellent work you have here, although the slider doesn't work on mobile, can you check that out. Well done mate
- @JuanCris09What are you most proud of, and what would you do differently next time?
I need to learn more CSS about reformat img, table and anything
What challenges did you encounter, and how did you overcome them?My challenge was about a line in the table
What specific areas of your project would you like help with?About the last line in the table I don't know delete this line
@samuel-aduTo remove the last line you can use the css last-child selector.
- @dimitrisdrWhat are you most proud of, and what would you do differently next time?
I am proud of taking this project so close to the original one. I think that I took my design skills a little step further.
What challenges did you encounter, and how did you overcome them?handling the image sizes is something that I got struggled with. In some cases for example in the extra articles section, when the screen goes very large, the spaces between the titles and the content increases a lot due to image resizing.
What specific areas of your project would you like help with?Handling the spaces between the titles and the content when the image size increases is something that I need to fix in my projects. Any suggestions are welcome!
@samuel-aduGood work with the solution, the only issue is the grid gutters which are inconsistent. If can make the whole content a single grid container and work downwards from there using consistent grid gaps in the children elements you will fix this issue.
Marked as helpful - @hilla10What are you most proud of, and what would you do differently next time?
it was difficult for me because this is my first time js project so I think I did good
What challenges did you encounter, and how did you overcome them?adding cart, counting, and removing this is from challenging
What specific areas of your project would you like help with?in the counter, and removing items
@samuel-aduExcellent work. Can you look into this bug i found, when I select an item and remove them, i was still able to place a order with zero quantity of that item.
Marked as helpful - P@Nyelus101@samuel-adu
Good work bro, especially the custom dropdown. I would like to see how you implemented it.
- @adarsh78What specific areas of your project would you like help with?
I would like to get help with my logic building and how optimized my code is and where can I improve myself. Any feedback is highly appreciated.
@samuel-aduThis is a very commendable solution. You should remember to update the readme incase someone visits your github and finds this project.
Marked as helpful - @dimitrisdrWhat are you most proud of, and what would you do differently next time?
It was my first time that I have tried to put aria-values that much. I think that i am starting to understand how this works.
What challenges did you encounter, and how did you overcome them?I am not sure that the code for evaluating validation of each input is the best. Also, I am not sure if the e.preventDefault() prevents the form from being rendered to the server or it is just prevents the page from reloading.
What specific areas of your project would you like help with?I would like to understand better the aria-attributes. More over I would like to understand better the functionality of the command e.preventDefault().
@samuel-aduevent.preventDefault()event.preventDefault() is a method in JavaScript that prevents the default action associated with an event from occurring.
The default action when a form is submitted is for the browser to send the form data to the server and reload the page, to prevent the page from reloading we use the event.preventDefault() method.
Marked as helpful - @adesholanaheem@samuel-adu
Hello your solution is not showing up in the preview.
- @Ay-dotcode@samuel-adu
Excellent work
- @samir-DeveWhat are you most proud of, and what would you do differently next time?
I will make it take less next time, it took 12 hours to finish this project.
What challenges did you encounter, and how did you overcome them?To break JS codes into smaller functions was a little bit challenging but I overcame ! :)
What specific areas of your project would you like help with?I welcome any feedback on my HTML semantics as it is very overwhelming !
@samuel-aduPlease check your calculations as it doesn't return the correct figures.
- @Ay-dotcode@samuel-adu
Excellent work, if you could make the data show 1hr and 0hr instead of 1hrs or 0hrs.
Marked as helpful
