@fsahinbasSubmitted 3 months ago
P
Samuel Adu
@samuel-aduAll comments
- @samuel-aduPosted 2 months ago
Another excellent work from you, could you also make it responsive.
Marked as helpful0 - @fsahinbasSubmitted 3 months ago@samuel-aduPosted 2 months ago
Good work Fatih!
I have a few suggestions to improve the design, especially the about and creation section.
- your main should wrap the image-interactive and the creations sections.
- the see all button in mobile should be after the creations card
- in desktop you can position the see all button to top right relative to the creation section
This should fix the creation section flowing out of screen in both mobile and desktop view.
Overall this a very solid work and its clean too.
0 - @vicymichealSubmitted 3 months ago@samuel-aduPosted 3 months ago
Good work, the solution very close to the design. In mobile view the card is touching the body of the device, if you could add paddings to both side of the container this will work.
Marked as helpful0 - @fsahinbasSubmitted 3 months ago@samuel-aduPosted 3 months ago
Excellent work you have here, although the slider doesn't work on mobile, can you check that out. Well done mate
0 - @JuanCris09Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I need to learn more CSS about reformat img, table and anything
What challenges did you encounter, and how did you overcome them?My challenge was about a line in the table
What specific areas of your project would you like help with?About the last line in the table I don't know delete this line
@samuel-aduPosted 3 months agoTo remove the last line you can use the css last-child selector.
0 - @dimitrisdrSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of taking this project so close to the original one. I think that I took my design skills a little step further.
What challenges did you encounter, and how did you overcome them?handling the image sizes is something that I got struggled with. In some cases for example in the extra articles section, when the screen goes very large, the spaces between the titles and the content increases a lot due to image resizing.
What specific areas of your project would you like help with?Handling the spaces between the titles and the content when the image size increases is something that I need to fix in my projects. Any suggestions are welcome!
@samuel-aduPosted 3 months agoGood work with the solution, the only issue is the grid gutters which are inconsistent. If can make the whole content a single grid container and work downwards from there using consistent grid gaps in the children elements you will fix this issue.
Marked as helpful0 - @hilla10Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
it was difficult for me because this is my first time js project so I think I did good
What challenges did you encounter, and how did you overcome them?adding cart, counting, and removing this is from challenging
What specific areas of your project would you like help with?in the counter, and removing items
@samuel-aduPosted 3 months agoExcellent work. Can you look into this bug i found, when I select an item and remove them, i was still able to place a order with zero quantity of that item.
Marked as helpful0 - @Nyelus101Submitted 3 months ago@samuel-aduPosted 3 months ago
Good work bro, especially the custom dropdown. I would like to see how you implemented it.
0 - @adarsh78Submitted 3 months agoWhat specific areas of your project would you like help with?
I would like to get help with my logic building and how optimized my code is and where can I improve myself. Any feedback is highly appreciated.
@samuel-aduPosted 3 months agoThis is a very commendable solution. You should remember to update the readme incase someone visits your github and finds this project.
Marked as helpful2 - @Schnedi3Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Modularize the code so much, next time will do something similar, but will start writing every component into it's own file
What challenges did you encounter, and how did you overcome them?There was some logic with the replies that got me stuck for some time, just tried a lot of console log outputs until I realize how to do it, after that, just tried to improve the code as much as I could
@samuel-aduPosted 3 months agoVery neat solution, but can you make it so that you cant vote more than once.
0 - @dimitrisdrSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
It was my first time that I have tried to put aria-values that much. I think that i am starting to understand how this works.
What challenges did you encounter, and how did you overcome them?I am not sure that the code for evaluating validation of each input is the best. Also, I am not sure if the e.preventDefault() prevents the form from being rendered to the server or it is just prevents the page from reloading.
What specific areas of your project would you like help with?I would like to understand better the aria-attributes. More over I would like to understand better the functionality of the command e.preventDefault().
@samuel-aduPosted 3 months agoevent.preventDefault()event.preventDefault() is a method in JavaScript that prevents the default action associated with an event from occurring.
The default action when a form is submitted is for the browser to send the form data to the server and reload the page, to prevent the page from reloading we use the event.preventDefault() method.
Marked as helpful0 - @adesholanaheemSubmitted 3 months ago
