@samritbasnetSubmitted 2 months ago
samritbasnet
@samritbasnetAll comments
- @samritbasnetPosted 2 months ago
thank you for comment that helped me with my functionality
0 - @LucasNgTgSubmitted 2 months ago
- @gideonakpanSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
Proud of completing the project, and using javascript to validate my form
What challenges did you encounter, and how did you overcome them?None
What specific areas of your project would you like help with?How to make my input background change colour
@samritbasnetPosted 2 months agopreety well done i would just recomend adjusting font size other than that looks good
Marked as helpful0 - @Jan-Dev0Submitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I used an SVG element for the popup triangle instead of the typical ::before and borders approach.
What challenges did you encounter, and how did you overcome them?I faced difficulties in getting the image to match the height of the adjacent column in the desktop view. I resolved this by adjusting the margins and paddings of the right column, making both columns visually balanced and aligned in height.
What specific areas of your project would you like help with?I would like to better understand how elements take up space and how they influence each other in terms of layout. Specifically, I'm interested in learning about the factors that affect the size and positioning of elements within a container and how these interactions can be managed.
- @dominguez-danielSubmitted 3 months ago
- @gk6294Submitted 3 months ago@samritbasnetPosted 3 months ago
overall good work i would be adjustting font color for paragraph of kira whittle and jeanete harmon in your site and increase the gap between the cards.
0 - @MusicalaudioSubmitted almost 2 years ago
Had some trouble with getting the right sizing in the desktop layout. Feel like the size of the cards are a bit too wide relative to the paragraph below the main heading.
As a whole it feels like it's too large, but that maybe due to my laptop having a small screen.
Any advice for sizing the desktop layout is appreciated.
@samritbasnetPosted 3 months agooverall it looks good.for me i did this way @media (max-width: 1140px) { .card-container { grid-template-columns: 1fr; }
.card:nth-child(n) { grid-column: 1; grid-row: auto; } }.And for card container property .card-container { display: grid; grid-template-columns: repeat(3, 10fr); gap: 20px; margin-top: 60px; }
0 - @dealencardavidSubmitted 3 months ago@samritbasnetPosted 3 months ago
i see the main border color is white for the elements you can adjust that other than that 169.99 looks to have letter-spacing which you can adjust.Anyways the final product looks amazing good work.
Marked as helpful1 - @ClemFranceSubmitted 3 months ago@samritbasnetPosted 3 months ago
i have seen few issue first would be the selection of background color and finally the table element is not inside the body element make sure the div section is inside it and be sure you gave right padding and margin.
0 - @reyes630Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Las habilidades de escritura han mejorado, trataría de usar menos codigo
What challenges did you encounter, and how did you overcome them?No enfrente ningun desafio
What specific areas of your project would you like help with?En la animacion al pasar el cursor
@samritbasnetPosted 3 months agoThe font color is not set properly for your project and the size of main content is not appropriate other than that spacing between element should be align properly and the sizing of the main element at bottom margin should be well kept.
0 - @jorgecorderozxSubmitted 3 months ago@samritbasnetPosted 3 months ago
I see your hover effect is not working in the page you can do that by adding following properties .title:hover { color: hsl(47, 88%, 63%); cursor: pointer; }.Other than that everything looks good for me.
Marked as helpful0 - @alexrtmSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I was able to get the component to look pretty similar to the design.
What challenges did you encounter, and how did you overcome them?The main challenge with this one was making sure the image was an appropriate size and was not overflowing its container. Setting the image to block display and giving it a max-width of 100% took care of the sizing issues. Using auto margins for the image made sure it was centered.
What specific areas of your project would you like help with?-
I would like feedback on the choice of my html elements and structure. Specifically, I would like to know if I chose the correct semantic elements.
-
In order to center the component in the body, I had to add this css rule:
html, body { height: 100%; }I am not sure why I had to do this, even when I made the body
display: flexand used center forjustify-contentandalign-items. -
Was it appropriate to give the body a flex display to center the component?
-
Did I properly size the component?
@samritbasnetPosted 3 months agoI would suggest you to flex-direction column and min-height property:100vh to maintain the size of component also margin of 0.
0 -
