faekhatami• 540
@faekhatami
Submitted
samir-Deve
@samir-Deve
All comments
- samir-Deve• 350
@samir-Deve
Posted
why did you upload it without applying css and js ?
0 - Nneoma Njoku• 1,210
@SatellitePeace
Submitted
I found the layout a bit challenging because i had to use a lot of positioning to get the layout which made responsiveness a bit of a hustle.
But i am happy with the end result.
I will happily welcome any advise that can solve the positioning issue so that i will use less of position:absolute in the future
I added a background color to the nav because i felt it made it a bit more visible
samir-Deve• 350@samir-Deve
Posted
you have not positioned elements beautifully, try harder !
0 - Yacine Kahlerras• 820
@yacineKahlerras
Submitted
experimented with grid a little bit, found a nice solution for making the SEE ALL button at the bottom of the grid in the mobile view without writing too much Css using
grid-columnandgrid-row.I tried to make it as pixel perfect as possible using Figma but at some point it seemed to me that it wasn't worthwhile since this isn't the point of all these challenges.
and if anyone has any suggestions on where i can improve on that would very awesome.
samir-Deve• 350@samir-Deve
Posted
I like how you positioned header text
0 - kerekiwere• 350
@kerekiwere
Submitted
samir-Deve• 350@samir-Deve
Posted
well designed
1 - Owolabi• 250
@Ay-dotcode
Submitted
samir-Deve• 350@samir-Deve
Posted
well designed
0 What are you most proud of, and what would you do differently next time?
completing the solution.
What specific areas of your project would you like help with?
Making the site more accessible.
samir-Deve• 350@samir-Deve
Posted
well designed
0- Edwin Cheng• 340
@edwinc73
Submitted
samir-Deve• 350@samir-Deve
Posted
well designed !
0 - M Ibrahim• 210
@misecond4747
Submitted
What are you most proud of, and what would you do differently next time?
This is very easy challenge for a person who is on intermediate level. Newbies should try, this challenge helps you understand the simplest use of JavaScript.
samir-Deve• 350@samir-Deve
Posted
well designed
0 - PSamuel Adu• 1,010
@samuel-adu
Submitted
samir-Deve• 350@samir-Deve
Posted
well designed !
0 - Abdi• 190
@abdizahir
Submitted
What are you most proud of, and what would you do differently next time?
completing this project, adding the json to the elements.
What challenges did you encounter, and how did you overcome them?
the js part, by searching and solving it.
What specific areas of your project would you like help with?
all of the project.
samir-Deve• 350@samir-Deve
Posted
You designed it beautifully !
0 - Vinncent Miller• 150
@centralparkshark
Submitted
samir-Deve• 350@samir-Deve
Posted
well done!
0 What are you most proud of, and what would you do differently next time?
I am happy, that I managed to tackle all mandatory elements of the project. I am satisfied with the look and also functionality of the result. It might not be a pixel perfect copy of the design, but that was not my primary aim. I aimed to use responsiveness best practices, and I think I did reasonably well in this aspect.
What challenges did you encounter, and how did you overcome them?
I wanted to use overflow: hidden to only having to use border-radius on the whole card, and the parts adapting automatically with the overflowing parts hidden. But that was not possible, because the share menu had to be able to overflow the card boundaries. So I had to find workarounds, without making the whole unmaintainable. So I decided to use custom properties, that I can change, so that everything that has to be consistent, changes together. Unfortunately, anchor positioning is lacking in browser support... maybe in the not so distant future... Another challenge was have the same share menu "behave" differently on small and large screens. I tackled this using container queries, and different values for absolute positioning.
What specific areas of your project would you like help with?
I would welcome any suggestions to make the code easier to maintain. I am aware of anchor positioning, but does not have enough support, yet. Any suggestion for a possible workaround (preferably css only) would be appreciated.
samir-Deve• 350@samir-Deve
Posted
You designed it better than me, hora to You !
0
