Sahil Atahar
@sahilataharAll comments
- @BoostSmothySubmitted over 1 year ago@sahilataharPosted over 1 year ago
Your App is not working. Check and fix it. Map be error in get-address.js file.
0 - @RealHustlerSubmitted over 1 year ago
Please take a look at my solution and please leave your feedback i will really appreciate.
@sahilataharPosted over 1 year agoCongratulations for project completion.
- You can fix position of attribution paragraph using CSS.
.attribution { width: 100%; font-size: 12px; text-align: center; position: fixed; bottom: 5px; left: 50%; transform: translateX(-50%); } .attribution a { color: #2c7dfa; }
- Give only 1rem padding in .container.
Marked as helpful0 - @Oneluv1Submitted over 1 year ago@sahilataharPosted over 1 year ago
Congratulation for Project Completion!
I'll suggest you to learn CSS at least basics Margin, padding, border-radius etc. You website alignment is not correct. You can checkout freecodecamp CSS tutorial and you can start with newbie and junior challenges and try to make exact same look then you can move on to the intermediate projects.
Marked as helpful0 - @kennsawyerrSubmitted over 1 year ago
I worked with css and html. I'm open for suggestions guys. Cheers
@sahilataharPosted over 1 year agoCongratulation for Project completion
Here is some suggestion for your project. I hope it may helpful.
(1). To center your card you can use:
/* using flex */ display: flex; justify-content: center; align-items: center; /* or using grid */ display: grid; place-items: center;
(2). Fix you credit position at bottom.
.attribution { width: 90%; position: absolute; left: 50%; bottom: 0px; font-size: 11px; text-align: center; transform: translateX(-50%); -webkit-transform: translateX(-50%); -moz-transform: translateX(-50%); -ms-transform: translateX(-50%); -o-transform: translateX(-50%); color: var(--white); }
0 - @PXVCSubmitted over 1 year ago
HI. This is my second React project, So it's a little buggy. And I have just finished my high school entrance exam, so I'm very tired. Because of this, my project is not finish just yet, I haven't do mobile design. So I'm love your suggestions for my project :)
@sahilataharPosted over 1 year agoHi I am Sahil Atahar. There is some issues in your project.
Here are solution of some problems:
- Hide input number arrow
/* Hide Input number arrow for Chrome , Safari*/ input[type="number"]::-webkit-inner-spin-button, input[type="number"]::-webkit-outer-spin-button { display: none; -webkit-appearance: none; margin: 0; } /* For Firefox*/ input[type="number"] { appearance: textfield; -moz-appearance: textfield; }
- Fix bottom credit paragraph:
/* For medium and large devices */ .attribution { width: 100%; position: absolute; bottom: 0; left: 50%; transform: translateX(-50%); font-size: 11px; text-align: center; -webkit-transform: translateX(-50%); -moz-transform: translateX(-50%); -ms-transform: translateX(-50%); -o-transform: translateX(-50%); } .attribution a { color: var(--purple); } /* For small devices */ .attribution { position: static; transform: translate(0); -webkit-transform: translate(0); -moz-transform: translate(0); -ms-transform: translate(0); -o-transform: translate(0); }
Marked as helpful1 - @Gitax18Submitted over 1 year ago@sahilataharPosted over 1 year ago
Using rem or em unit is better. It you want to change border radius according font size.
1