👨💻 Hello guys. This is my resolution for the QR Code Component challenge. I was challenged by my friend @correlucas to redo this challenge and improve it.
I added some details:
Feel free to leave feedback on how I can improve my code. 😊 Thanks!
The only thing that is missing in dark theme is:
.attribution{
color: white;
}
Will done!
Q) how can I rotate the arrow is there any css pseudo selector or do i have to do it in javascript? Q) any improvement or any mistake ?
Hi Amaar,
you can do transform: rotate(180deg); to rotate it.
also you can use
<details>
<summary>How many team members can I invite?</summary>
You can invite up to 2 additional users on the Free plan. There is no limit on
team members for the Premium plan.
</details>
its better than button and divs see => How to use details. the thing is if one is open and i try to open other one, the js close the first one and keep the one that i opened after closed.
Organization was very difficult.
There are many things I would do differently:
The general organization seems chaotic. Some variables could be made global but I had issues passing them into sub-functions and using them in there.
Is there a better/simpler way of destructuring or manipulating NodeList's?
Hi i just tested a bit your site! super nice i should say!
the problem i found:
-when selecting X as start valeu, the hover button .game-board .game-board-grid .space:not(.clicked):hover display's icon-o-outline.svg not the icon-X-outline.svg
start a game with O click once in the grid then reset to and chose X. you will see the hover is O.
-the maine page when you hover on x , o diseper . i think its better to gray it out or only lower the transperty ot hide it.
hope it was helpful!
Hi
This is my third template project and I want to build some others. Please check my solution and tell me if this is correct enough and acceptable or not. I tried to be precise in estimating sizes in pixel correctly but I'm not sure it is true or not. I appreciate if there is a determined way, inform me that.
thank you for your response in advance
Hi Kowsar, It is better to start deploying the landmarks tag's. They are:
<nav> here is between the site pages navigations or even sections in the sape page with id</nave> <main> here goes your view page</main> <section> this is inside the main usually and normally there is more than one</section> <footer> here goes the things in the end, like "Challenged by.. Coded by .." </footer>You won't have any problems changing the word "div" to one of those landmarks.
Hope it helped 🐼
