Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Gakii 470

    @G-Gakii

    Submitted

    What are you most proud of, and what would you do differently next time?

    Ability to validate form using javascript

    What challenges did you encounter, and how did you overcome them?

    No new challenge

    What specific areas of your project would you like help with?

    If any feedback to improve I will appreciate

    P
    rtoddm 80

    @rtoddm

    Posted

    Looks good! Nicely done!

    Although this project doesn't have a ton of JS, I might suggest some notes in your JS just to make it easier to read.

    Marked as helpful

    0
  • @nullpuppy

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm pretty happy with the transitions for the display of the share links, and with the general layout of the code. There's a few things I'd like to look at doing a little differently for better consistency (like the layout of the footer of the card when the links show up). Maybe something to look at in the future.

    What challenges did you encounter, and how did you overcome them?

    Getting the image aligned right was a bit of a nightmare. I tried a bunch of things, most of which I don't remember, until I managed to get it looking right.

    The pointy bit on the desktop view of the share links was new for me, but turned out to be pretty easy to implement.

    What specific areas of your project would you like help with?

    Any feedback is appreciated. Thanks!

    P
    rtoddm 80

    @rtoddm

    Posted

    Really nice work on this site. I wish I could offer some helpful advice but I think I actually learned some things by looking at your code! Keep up the good work!

    0
  • RohanIV 160

    @RohanIV

    Submitted

    What are you most proud of, and what would you do differently next time?

    Implementing JS, still don't fully get it but managed to make it work.

    What challenges did you encounter, and how did you overcome them?

    Getting JS to work. A lot of research and video watching.

    What specific areas of your project would you like help with?

    1. When I extend each question, on the smaller screens the background doesn't extend to the bottom and leaves a blank space. Don't know how to fix it.
    2. Any tips on make my JS code more efficient if needed.

    2a. And any tips on getting better at JS. (still gonna keep practicing)

    Thank you in advanced

    P
    rtoddm 80

    @rtoddm

    Posted

    Hi RohanIV,

    I don't know how much help I can be as I am still learning myself. However, it looks like your live hosted site isn't linked correctly. I wanted to take a look but wasn't able to...if you want to double check that then perhaps I can take a look and see if I can offer any helpful feedback.

    0
  • P
    rtoddm 80

    @rtoddm

    Submitted

    What are you most proud of, and what would you do differently next time?

    This is a simple project but it my first non-tutorial project since learning to code so I am proud of simply being able to complete it on my own.

    What challenges did you encounter, and how did you overcome them?

    The main difficulties that I encountered were learning to get the appropriate information from the Figma file and getting the page to display properly on GitHub Pages (it was a file path issue).

    What specific areas of your project would you like help with?

    Have I completed this challenge as intended? The design file in figma does not show any additional background but the "preview" file shows an additional background applied behind the grey box background.

    P
    rtoddm 80

    @rtoddm

    Posted

    Hi @Johann-Alpha, thanks for the feedback! Perhaps I'm just a bit confused as to the directions for the challenge. The description says this is a good challenge if you haven't learned about building responsive websites yet. So I admittedly was unclear as to what that meant since there was a mobile and desktop view. Can you help clarify for me? Thanks for the help!

    0