Lord-Ace• 80
@lord-Ace
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud of the speed of completion and the rate at which my development skills have improved and I want to learn to style better
Roni Tovar
@ronitzdev
All comments
- Roni Tovar• 270
@ronitzdev
Posted
Hi, I see that you have added the font to the code, but you need to add the font family property to the body, also reduce a little the padding to the buttons; and to the sentence that follows the location add a suitable gray color without losing visual accessibility. In addition to leaving the buttons with a width of 100%. Topics such as the BEM convention can be useful. Practice with an interactive game like flexbox froggy to reinforce knowledge.
0 - Christian Benitez• 10
@ChrissBenitez
Submitted
What are you most proud of, and what would you do differently next time?
Using git to publish on github pages, I had never used it.
What challenges did you encounter, and how did you overcome them?
centering vertically the element, I used absolute position
What specific areas of your project would you like help with?
Nothing so far so good.
Roni Tovar• 270@ronitzdev
Posted
Hi, I found your project very nice. As for the image container, you can use the figure tag with the same .qrcode--image class. You can also add the property left and rigth in the developer attribution with a value of zero to center it, a background color like white, and padding up and down. To make it stand out and look clearer. And in the text a font size in rem unit. Mostly because it is used professionally. Otherwise fine.
Marked as helpful
1 - Basomka• 60
@Basomka
Submitted
Roni Tovar• 270@ronitzdev
Posted
Hello, to improve the visualization of your project on mobile, I recommend you to modify the height of the body tag with an automatic value, a padding of 10px and a padding of 1rem to the text container. I have invested on the BEM methodology for the html structure.
0
