Skip to content
OverviewSolutions
5
Comments
6
romyanand
@romyanand

All comments

  • romyanand•70
    @romyanandPosted about 1 year ago

    Great work 👍👏.

    0
  • Qasem Ezzaldeen•100
    @qasem-ezzaldeenSubmitted about 1 year ago

    It was pretty easy as my first challenge after completing a course in CSS. I look forward to solving more challenges.

    Results Summary challenge

    1
    romyanand•70
    @romyanandPosted about 1 year ago

    Congratulations on completing your first challenge. Great start👏. All the best 👍

    1
  • William Smith•10
    @WillxWinterSubmitted about 1 year ago

    This challenge wasnt so bad, my main struggles were with centering my content. I overlooked alot of simple things that, like styling elements as they are. I had created too many unnecesary divs.

    QR Code Card

    2
    romyanand•70
    @romyanandPosted about 1 year ago

    Hey👋. First of all congratulations for completing the challenge. I saw the GitHub code, and certainly, there are not many unnecessary divs in my opinion. Although you can do these things to make it more like the design provided if you would like to do so:

    1. I wouldn't suggest defining a height/min-height/max-height for the body. Height is something that's already adjusted as our content grows and shrinks. If you want to make something look a bit more in height, you can add top and bottom padding.

    2. You can also define a min-width and max-width for the container. Being said all this, Your design looks great👍. All the best!

    Marked as helpful
    0
  • romyanand•70
    @romyanandPosted about 1 year ago

    Great design. Looks professional and I loved that circle's design✨. All the very best👍

    0
  • romyanand•70
    @romyanandPosted about 1 year ago

    The desktop, design looks great and absolutely professional. Just a little thing to add in mobile design,

    1. When adding the perfume image, there are two images provided: one for desktop and one for mobile.
    2. You have already added the desktop image in your code, you can add the mobile.
    3. Add the breakpoint using media queries and toggle the display based on the screen width. All the best!👍
    1
  • romyanand•70
    @romyanandPosted about 1 year ago

    Hey Juan, as per the design provided in the challenge, you can put "Summary", "button" and all the brief results below it in a container. Also, it would be better if the right side of the card also had some border-radius. Everything else looks great. Congratulations on completing the challenge.

    0