romannst
@romannstAll comments
- @RongbungbuSubmitted about 2 months ago@romannstPosted about 2 months ago
Hello Selena, you've submited the solution of other challenge. Check the challenge that you've done and post it in the correct place.
0 - @juan-mentorSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
- De empezar a hacer un código algo más accesible, aunque aún estoy en pañales.
- Como la card es un contenedor independiente a lo mejor sería más conveniente poner un article y subdividirla en un header, content y footer.
- En esta ocasión y gracias al aprendizaje obtenido a través de Learning Paths, no he tenido ninguna dificultad.
-
Quizás en el tema de accesibilidad, que me parece un gran acierto por parte de los desarrolladores.
-
Toda ayuda es bienvenida, al igual que todo comentario sobre por donde empezar a explorar dicho tema.
@romannstPosted about 2 months agoHey Juan! Great job with this solution, I noticed that you frequently use pixels. You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why you shouldn't use pixels for font-size.
0 - @AllanSancleySubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
- Me orgulho de concluir o objetivo de deixar o pagina conforme o design.
-
O principal desafio foi o alinhamento tanto das linhas quanto das palavras para deixar conforme o design, e as sombras do cartão.
-
Fiz algumas pesquisas e encontrei alguns artigos sobre o assunto que tiraram as minhas dúvidas.
@romannstPosted 2 months agoHi Allan, I see your solution has some common issues that affect responsive design on different devices:
- First i recommend u to use a modern css reset, Andy Bell or Josh Comeau both have good ones.
- Remove the width and height on the general box (the card). You don't need that. All it needs is a single max width in rem.
- The container class need min-height 100svh along with flex column properties to center. It's the browsers job to decide how tall the component needs to be.
I'm also just starting out, so it's good for me to try to help people who are going through the same path. Good luck with your upcoming projects!
0