All comments

• 

  Elijah Plushkov•40

  @ElijahPlushkovSubmitted about 1 year ago

  Hello! My questions are:

  1. Do I use the media-queries correctly?
  2. How can I improve on using them?

  

  Results summary component using grid and media queries

  1

  20
  

  Rohmat Setiawan•60

  @rohmatsetiawanmtaPosted about 1 year ago

  Hello.. I have some feedbacks to your solution..

  Font Family

  It seems like the font family is not showing up in the preview. Here is one way you can try to ensure the font family is displayed in the preview. You can add the following code to the first line of your CSS file.

  @import url('https://fonts.googleapis.com/css2?family=Hanken+Grotesk:ital,wght@0,500;0,700;0,800;1,500;1,700;1,800&family=Space+Grotesk:wght@500&display=swap');
  

  Padding

  It would be better if the 4 section in summary sections and the continue button are given more padding. Adding padding can give a neater impression because it's not too close to the border.

  But, this is a very good start! Good job!

  Marked as helpful

  0

  This comment has received 2 repliesShow
• 

  Dawid "makaroni" Markieton•140

  @greenMakaroniSubmitted about 1 year ago

  Hello frontendmentor.io

  

  Quite basic solution to the QR code component challenge.

  1

  50
  

  Rohmat Setiawan•60

  @rohmatsetiawanmtaPosted about 1 year ago

  Hi, I believe the heading could be improved with a slightly larger size. It would also be helpful to split the HTML and CSS codes for easier modifications in the future. But on the whole, everything is well done!

  Marked as helpful

  1