All comments

• 

  Marwan Zayed•30

  @marwanzayedSubmitted almost 3 years ago

  Welcome, I hope that you will tell me your evaluation of the site and give your rating out of 10, as this makes a difference with me very much, I leave you with the site, thank you <3

  

  Order Summary Card (HTML, CSS)

  2

  50
  

  Rogerio Bautz•180

  @rogeriobautzPosted almost 3 years ago

  You are using a span tag as a div, wrapping the music icon and a div with 2 texts. Span tags can not have divs inside. Remember to update your CSS code too since you are using it in line 71.

  1

  This comment has received 1 replyShow
• 

  Tobias Sirianni Melo•20

  @tsirianniSubmitted almost 3 years ago

  Hello, everyone! This was actually my first project really "on my own". Any feedback would be not only welcomed, but also appreciated.

  

  Desktop-first solution using SCSS and Flexbox

  1

  60
  

  Rogerio Bautz•180

  @rogeriobautzPosted almost 3 years ago

  Your card looks good with width on 320px, after that it gets confused. I took a look on your code and saw that your using a lot of vh and vw to make your site responsive. I think using px or rem with breakpoints is much easier. Example: your card is set to be 28vw after 375px, that is good in a desktop with +1024px width but in a mobile or a tablet it is deformed.

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Rogerio Bautz•180

  @rogeriobautzSubmitted almost 3 years ago

  Edit: I changed the tags to resolve acessibility issues. use min-height in the body and removed the height from the card. It seems fine.

  I had some throubles using Chrome developers tool to see the card responsiveness. Sometimes worked just fine sometimes it was way off center. Is there a better way to do this without the developers tool?

  I want a feedback about position and opacity used to do the overlay over the nft image. It did the work but I am not sure if it is the best way to do this.

  

  Card component using CSS flexbox and overlay

  3

  50
  

  Rogerio Bautz•180

  @rogeriobautzPosted almost 3 years ago

  @brodiewebdt I made the changes that you suggested.

  1