JIJO1508• 10
@JIJO1508
Submitted
Rodrigo Lira
@rodrigoronin
All comments
- Rodrigo Lira• 20
@rodrigoronin
Posted
Do not use <br> for spacing between elements, use css instead. It is not a good practice anymore because semantics.
Try to layout the elements by blocks, finding what can be arranged together in sections will make things easier to maintain later, it doesn't matter for the current challenge, but make this a practice in your daily job.
0 - darkogj• 10
@darkogj
Submitted
What are you most proud of, and what would you do differently next time?
I figured out how to vertically center the card.
What challenges did you encounter, and how did you overcome them?
Vertically centering.
What specific areas of your project would you like help with?
Alternatives approaches for both horizontal and vertical centering.
Rodrigo Lira• 20@rodrigoronin
Posted
Hello @darkogj,
By reviewing your project I have some advices that can help you improve.
Try to separate the content of your page in blocks, for example, in the challenge we have a main section to handle the content and inside it we have an image and some texts. You could have created a div to wrap the image and on for the texts, it would be better for maintenance:
<main role='main'> <div class='main-content'> <div class='qrcode'> <img> </div> <div class='texts'> <h1>Big text</h1> <p>Small text</p> </div> </div> </main>With time and practice you'll learn how to structure your pages.
0
