All comments

• 

  rkrawczyszyn•10

  @rkrawczyszynSubmitted about 1 year ago

  Hi!

  The implementation lies in src/components/solutions/interactive-rating. I would love to receive feedback mainly about the SCSS parts:

  • should I use BEM and if yes - how?
  • do you think I organized my styles OK? how would you write styles and seperate them into files/mixins to make component reusable and ship it anywhere?
  • I have an issue makred as "todo - fix" in InteractiveRating.tsx. because of the way I wrote css and JS logic, I'm forced to use inline style, which is antipattern (afaik)

  I need mainly CSS feedback, as during daily work I hardly write CSS, mainly React TypeScript... Thank you!

  

  interactive-rating-component - React App with SCSS styles

  2

  30
  

  rkrawczyszyn•10

  @rkrawczyszynPosted about 1 year ago

  Hi Philip!

  Thank you for your time and feedback! I love your tip with the body css and I applied it :)

  I think giving the container more max-width is a bad idea. The component looks to wide to my liking and also - fits less to the expected design in the challange.

  And yeah, I could program it to make 1st step to disappear and show only the "thank you" component, but I think it's better to keep them next to each other. Well, it's not an app, it's just a coding challange :)

  Cheers from Poland!

  1