@kcdeSubmitted about 4 years ago
feedback on design?
Rita
@ritapetilloAll comments
- @ritapetilloPosted about 4 years ago
Hi, Looks good! I'd suggest to give the faq container a higher lateral padding so that that the arrows are not that close to the border. The rest looks alright!
0 - @tafnesjSubmitted about 4 years ago
I'd like to receive feedbacks from my code. Any comment is helpful regardless of scope.
@ritapetilloPosted about 4 years agoHi, good job!
The only thing, I would fix the responsiveness of the layout between width 400px to around 1250px. I can see some problems with both the hero section and the testimonial section below (the boxes alignment and the text inside boxes).
1 - @dansonmainaSubmitted about 4 years ago
how to get the exact solution of the design?
@ritapetilloPosted about 4 years agoHi, you can check my solution. It's not perfect, but I think it's quite close to the original one. I've also implemented API. In the main.js file I commented everything step-by-step. https://www.frontendmentor.io/solutions/shortly-project-htmlcss-flexbox-grid-js-api-mobile-first-bGYkRtsuM
0 - @sammyslackSubmitted about 4 years ago
Don't know why my CSS is not reflecting after hosting on github
@ritapetilloPosted about 4 years agoHi, I've checked your code and it's an easy fix. Your style.css file is in the root folder and not in a css folder. Therefore you should change the path to your css file in this way: <link rel="stylesheet" href="styles.css">
and not <link rel="stylesheet" href="css/styles.css">
0 - @AlpascSubmitted about 4 years ago
Didn't know how to handle the change between mobile screen and desktop screen... please let me know how you're used to do it.
Thanks !
@ritapetilloPosted about 4 years agoHi, the proper way to make your website responsive is setting up media queries. With media queries you can set up breakpoint and style certain elements based on the size of the screen (breakpoint).
What I usually do is opening Chrome developer tools and check how the design of the page reacts when I shrink the page width. When I see that the design starts to be off, I write down the breakpoint and I write a media query to fix those elements of the page which don't behave appropriately for that screen size.
In your code, if you want to make the website more responsive, you can try to write other media queries for different breakpoints.
2
