Skip to content
OverviewSolutions
7
Comments
3
Sebastián Peña Jorquera
@retrovertigo1981

All comments

  • Sebastián Peña Jorquera•90
    @retrovertigo1981Posted almost 3 years ago

    Hola @PhynxMorales!

    Excelente trabajo con tu código, felicitaciones, lo único que encontré que puedes mejorar es ajustar un poco la medida del efecto hover en la imagen, ya que por lo menos en mi navegador tiende a salirse un poquito del borde de la imagen, seria lo único que podría mencionar, el resto del código esta muy bien a mi parecer. Felicitaciones nuevamente.

    Si gustas puedes revisar mi solución al desafío y comentar al respecto:

    https://www.frontendmentor.io/solutions/ntf-card-component-using-html-and-css-Dn9cJV3YP

    Saludos desde Chile.

    Marked as helpful
    0
  • Ashley•20
    @ashhh266Submitted almost 3 years ago

    Here is my first attempt at this challenge. Took forever to get the hover effect on the main image. This is my 2nd challenge (ever). Any feedback is greatly appreciated!

    NFT preview card challenge from frontend

    2
    Sebastián Peña Jorquera•90
    @retrovertigo1981Posted almost 3 years ago

    Hi Ashley!

    Excellent work, congratulations.

    If you like you can check my solution to the challenge and comment on it:

    https://www.frontendmentor.io/solutions/ntf-card-component-using-html-and-css-Dn9cJV3YP

    greetings from Chile

    cheers~

    0
  • Sebastián Peña Jorquera•90
    @retrovertigo1981Posted almost 3 years ago

    Hello, I was reviewing your code and you did a very good job, congratulations for that. There are some things that you can improve, since I realized the hover effect of the image is outside the card, maybe using a position:absolute to the image and a display:flex in the parent container would be better. My recommendation is that you take a look at the BEM methodology for class naming and study the use of priorities and specificity in CSS, that could help you a lot to improve your code. If you like you can review my solution to the challenge and comment on it.

    https://www.frontendmentor.io/solutions/ntf-card-component-using-html-and-css-Dn9cJV3YP

    greetings from Chile

    ~cheers

    0