Skip to content
OverviewSolutions
1
Comments
4
rejin-kumar
@rejin-kumar

All comments

  • omk963•40
    @omk963Submitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    This was my first time implementing Tailwind-CSS and I'm still learning. I hope to be able to apply custom Tailwind classes to make the code less bulky.

    What specific areas of your project would you like help with?

    Right now, the code is repetitive and not as clean as I want it to be. This includes the Tailwind-CSS. There's a few repeat classes that I would've liked to make a custom class for but I wasn't sure how to.

    Tip Calculator Using Tailwind CSS

    1
    rejin-kumar•40
    @rejin-kumarPosted 4 months ago

    Using radio buttons instead of normal buttons for tips could simplify your logic a bit. Hope it helps :)

    1
  • rejin-kumar•40
    @rejin-kumarPosted 4 months ago

    First of all well designed, its an exact replica. Few things I noticed though: Your calculations seem to take 15% by default without the button for 15 being active. The calculations seem to happen in the initial stage where the number people have not been entered, essentially assuming it to be for 1 person by default while the number of persons field shows 0. The user can delete the number of persons and your calculations say Infinity (Js dividing by 0). You can improve the code by having the calculations show 0 until all the fields have been entered. You can also use radio buttons instead of normal buttons for tips, this will simplify the logic a lot. Hope it helps :)

    Marked as helpful
    1
  • Samiullah•440
    @samir-DeveSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I will make it take less next time, it took 12 hours to finish this project.

    What challenges did you encounter, and how did you overcome them?

    To break JS codes into smaller functions was a little bit challenging but I overcame ! :)

    What specific areas of your project would you like help with?

    I welcome any feedback on my HTML semantics as it is very overwhelming !

    CSS, HTML, JS

    2
    rejin-kumar•40
    @rejin-kumarPosted 4 months ago

    Using radio buttons instead of buttons for the tips will simplify the code a lot. Hope it helps :)

    0
  • Gilang Aditya•425
    @madegilangadityaSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    Just create the vanilla JS function for calculator myself. There is some code that can be optimize on that function.

    What challenges did you encounter, and how did you overcome them?

    The challenge is more on calculation logic function since it used buttons and custom input field to do the tip calculation. Just got the foreach function on these vanilla JS

    What specific areas of your project would you like help with?

    Just need some feedback on my javascript code if there need some improvement that can be make in future.

    Tailwind CSS with Vanilla JS Tip Calculator

    1
    rejin-kumar•40
    @rejin-kumarPosted 4 months ago

    Using radio buttons for the tip selection instead of buttons (with an optional field for custom tips, which would be used only if there is a non-zero value in it) would have simplified the code a lot. Hope it helps! :)

    1