Skip to content
OverviewSolutions
8
Comments
6
Rau
@raubaca

All comments

  • Clara•50
    @clarabackerSubmitted 9 months ago

    • Which parts of the project do you think could be improved and why?

    • How well does the project respond to different screen sizes and devices? Are there any areas that could be improved for better responsiveness?

    • Is the code easy to read and understand? Are there any areas where I could improve code readability or use more meaningful variable/function names?

    • I am keen on learning more about frontend development best practices. Did you identify any aspects where I could improve in this regard?

    Responsive landing page using Flexbox and CSS grid

    1
    Rau•250
    @raubacaPosted 9 months ago

    Hi Clara,

    One thing you can improve is to change the card number input type from "text" to "number" and hide the input arrows with CSS. You can also set a min="0" attribute to the input so people don't input negative numbers.

    Good job!

    Marked as helpful
    0
  • Rau•250
    @raubacaPosted 9 months ago

    Hi Ruben, some observations:

    • You don't need to add <br /> in the HTML to generate spaces, just use the CSS margin property.
    • The title font is different from design, try to adjust the font-family and font-weight properties.
    • The selector .card.one button:nth-child(8) can be simplified to .card.one button.

    Good job!

    Marked as helpful
    1
  • Marcos Vinicius•190
    @AvantiermvSubmitted 9 months ago

    Hello everyone. I had some difficulties with my CSS because I didn't focus on it, but on Javascript. I tried to use the event listener and it was easy to learn about it. But now I'm going to study more about CSS because I need to study more about it. If you have any way of helping me, I'd be very happy

    Site a little responsive and interactive.

    1
    Rau•250
    @raubacaPosted 9 months ago

    Hi there!

    Some good resources where you can learn more about CSS:

    :)

    1
  • Rau•250
    @raubacaPosted over 1 year ago

    Hi Gustavo, you can improve the title by adding some spacing between the letters and increasing the font weight:

    .title {
...
letter-spacing: /* spacing value */
font-weight: 700 /* included with google font import */
}

    Good work!

    Marked as helpful
    0
  • newtothis90•240
    @newtothis90Submitted over 1 year ago

    If anybody would like to go through the HTML or CSS, and show me any improvements that would be used in REAL LIFE practice, please do so!

    QR-Code component using CSS Grid

    2
    Rau•250
    @raubacaPosted over 1 year ago

    Hi,

    You can improve your code by learning semantic HTML elements. For example, you can replace the container <div id="container" role="main container"> with <main id="container">. Another thing could be, don't use ids (#id) for styles, use classes (.class) instead. Good work!

    Marked as helpful
    1
  • Rau•250
    @raubacaPosted over 1 year ago

    Hi Monica,

    Your solution is visually excellent, but I have encountered some issues:

    • When I filter by region, the region name doesn't appear in the select.
    • After filtering by region, the search input is disabled.
    • When I search by name, the item link in results is wrong, it is the same as the previous item in that position.

    So far that's all I've found, great job!

    Marked as helpful
    0