sheralkaren• 50
@sheralkaren
Submitted
Dharmendra Rathod
@rathoddharmendra
All comments
- Dharmendra Rathod• 190
@rathoddharmendra
Posted
It looks great. Keep up the good work
0 - Karen Robertson• 190
@indigorose
Submitted
Dharmendra Rathod• 190@rathoddharmendra
Posted
Hey,
Overall site looks really cool. One suggestion
- you can reduce the margin for top of card to better position the content in center https://github.com/indigorose/frontend_mentor_hosting/blob/main/product_preview_card/style.css#L53C10-L53C21
keep up the good work.
0 - Dharmendra Rathod• 190
@rathoddharmendra
Submitted
What challenges did you encounter, and how did you overcome them?
responsiveness breaks after 1440px . Yet to figure out
What specific areas of your project would you like help with?
Building responsiveness for all screen while using flex and grid.
Dharmendra Rathod• 190@rathoddharmendra
Posted
The page responsiveness doesn't really work on all the screen size with images without adding multiple media queries breakpoint. Is there a better way? Is anyone facing the same problem with grid?
0 - sheralkaren• 50
@sheralkaren
Submitted
Dharmendra Rathod• 190@rathoddharmendra
Posted
Looks pretty good
Marked as helpful
0 - Sohrab Hossain• 40
@planner-sohrab
Submitted
Dharmendra Rathod• 190@rathoddharmendra
Posted
Here are few of my observation :
- Page can be aligned to center. As of now, it looks more inclined to left.
- Page behaves well within 375px screen size
0 - Nalish• 40
@Nalish
Submitted
Dharmendra Rathod• 190@rathoddharmendra
Posted
@Nalish, code looks really good. One suggestion to add responsiveness below 800px, as you can notice it;s behaving differently below this point. Keep up the good work!
Marked as helpful
0 - Atakula Pranav Reddy• 40
@PranavReddy2703
Submitted
Dharmendra Rathod• 190@rathoddharmendra
Posted
Overall page looks really good.
One suggestion that I can make regarding the responsiveness below 375px. -> You can use percentage instead for better responsiveness. https://github.com/PranavReddy2703/blog-preview-card/blob/main/style.css#L118C16-L118C22
Marked as helpful
0 - Basma-Bensadi• 20
@Basma-Bensadi
Submitted
Dharmendra Rathod• 190@rathoddharmendra
Posted
I really liked that you use multiple divs to manage each group better. Few of the improvements I noticed are:
- Using sizing on image twice - once as img attribute and on img selector in CSS
- missed to add color: grey on class="text"
- suggestion: using relative sizing like percentage or rem is better for responsiveness overall than px
As I said, overall the code works really good. I hope my review helps you :)
0
