All feedback should come in
Purvi Porwal
@purviporwal1812All comments
- @BensaxxySubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?@purviporwal1812Posted 5 months ago
For large number of days it is printing NaN, i believe its an error and should be handled by either a text showing large number, or something.
Marked as helpful0 - @lyes-merselSubmitted 5 months ago@purviporwal1812Posted 5 months ago
Kudos for completing the challenge! I believe the search bar should search after typing each letter, you can actually use filter and then includes method in js.
Marked as helpful1 - @Asv000Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I want to make it faster. I think it definetly takes me too long to make kinda simple layout.
What challenges did you encounter, and how did you overcome them?Biggest challenge was 01 and 02 elements as dividers on side. They were weird and I needed to Google how to achieve that.
What specific areas of your project would you like help with?I think that my code is a big mess, especially CSS one. I hope I used rem values correctly.
@purviporwal1812Posted 5 months agoLoved the website, Kudos to your efforts! Also, you can use framer motion for animations, i loved exploring it with react, you can also try it.
0 - @MaracaraCarlosSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I had a lot of fun making this App, I also took the opportunity to use Reactjs and put useState, useEffect and useContext into practice.
Built with:
- Semantic HTML5 markup ✨
- Flexbox 🤸♂️
- CSS Grid 🌐
- React ⚛️
- Sass 🎗️
@purviporwal1812Posted 5 months agoYou can make it responsive using bootstrap or tailwind, looks pathetic on mobile. Loved the page on desktop.
0 - @xmaxishhSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I am very proud to have completed the Frontend Mentor challenge and implemented a dynamic message with a responsive and functional design. Next time, I would like to focus more on the initial project planning to further optimize my time and resources. I also think I could have improved the CSS code structure to make it more modular and easier to maintain.
What challenges did you encounter, and how did you overcome them?I encountered several challenges during the Frontend Mentor challenge. One of the main challenges was implementing a complex responsive design with dynamic messaging. To overcome this, experimented with different CSS techniques for layout and responsiveness. Additionally, managing my time effectively while maintaining code quality was another challenge. I addressed this by setting clear milestones and conducting regular reviews to ensure I stayed on track. Utilizing resources such as online tutorials and the Frontend Mentor community also provided valuable insights and support.
What specific areas of your project would you like help with?I would appreciate help with optimizing the performance of my project, particularly in refining the CSS structure to make it more modular and easier to maintain. Additionally, I'm interested in learning best practices for enhancing accessibility features and ensuring compatibility across different browsers. Any guidance on improving overall user experience through smooth interactions and responsive design would also be valuable.
- @randomduckduckSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
Implemented using React router - no page reloads for each link click! Thought would take lots of time, but was a breeze actually.
Also changing css variables using js was new and I feel the possiblities are endless with css-variables and js combo - We can change anything, apply styles to many (even ALL ) elements with just a click. Its cool.
What challenges did you encounter, and how did you overcome them?flex box related issues. I was trying to make site responsive without using media queries, and spent a lot of time. But media query is made for a reason, and finally used it. took less than 10 mins to make it responsive actually. Right tool for the right job they say. Lesson learned.
Also in previous projects, for changing the border color of inputs when they are in focus I used to change accent-color property. But because this project requires both light and dark view, the limitations of that approach came forth. Then I got to know that there is a property called outline which handles that. Good to know!
What specific areas of your project would you like help with?No help required for now. I believe all things are done. Thanks
@purviporwal1812Posted 5 months agoAntarctica card is not opening (idk if it is domain specific) maybe it could happen with other cards also, you can check once. Ps. I loved the fact that countries are sorted alphabetically.
Marked as helpful0 - @Kikino02Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
@purviporwal1812Posted 5 months agoThe solution is amazing and is exact as the design !! I think if a user enters text instead of number in any of the placeholders, it should give a kind of alert like error handling should be done.
Marked as helpful0 - @jakubSerokSubmitted 11 months ago@purviporwal1812Posted 11 months ago
Hello @jakubSerok!
Your project looks great!
I have just one suggestion for improvement: You can increase the height of the navbar to make it more readable, and the cart should also display the number of items added. Other than that, your solution is very good!
0 - @chuantiongSubmitted 11 months ago@purviporwal1812Posted 11 months ago
Hello !
Your project looks great!
I have just one suggestion for improvement: You can add hover on the notify button as well as the input button
Other than that, your solution is very good!
0 - @OlokoburnfireSubmitted 11 months ago
i just completed this and I'll appreciate your feedback guys
@purviporwal1812Posted 11 months agoyou can add some sort of scroll animations to make it look more attractive
1