Skip to content
OverviewSolutions
18
Comments
6
Emmanuel Oluwatobiloba
@purrrplelipton

All comments

  • Rachel Pizane•60
    @rachelpizaneSubmitted 11 months ago

    Hi Guys! 😊

    In this project I had a hard time positioning the elements so that everything fit on the page, without having to scroll. (Desktop)

    Sometimes I feel like I add a lot of justify-* or align-* without need. It still gets confusing when I use display: grid or display: flex.

    As I didn't study Media Query and I only used them a few times, I don't know if I used them correctly.

    What did you think? Could you give me feedback? Did I use Media Query correctly?

    Three Column Preview Card using basic CSS custom properties

    3
    Emmanuel Oluwatobiloba•380
    @purrrpleliptonPosted 11 months ago

    I believe as a developer - a relatively new one at that - you do whatever you have to do, to get the desired result, so don't worry yourself too much for using a particular property too much. somthings i noticed:

    • you don't want to hardcode the height of the body, instead of height: 100vh; use min-height: 100vh; instead
    • padding on the body too isn't necessarily bad, but it isnt commom practice

    to name a few, overall, good job

    Marked as helpful
    1
  • Emmanuel Oluwatobiloba•380
    @purrrpleliptonPosted about 1 year ago

    Generate an updated Screenshot :)

    Marked as helpful
    0
  • Emmanuel Oluwatobiloba•380
    @purrrpleliptonPosted about 1 year ago
    • The card isn't on the page's center, consider using a display flex on the direct parent of the card then margin auto on the card itself
    • The background's SVG repeats, consider adding a no-repeat to the background
    • The illustration image overflow, consider adding an overflow hidden to the card
    • The 'Proceed to Payment' button doesn't seem to have the box-shadow that the original has
    • The plan's pricing section has a background colour that's to deep compared to the original

    making those corrections should make your solution match more closely to the original

    0
  • Jackson Whiting•360
    @jacksonwhitingSubmitted about 1 year ago

    I had two issues with this app (by the way, this was my first time working with third party APIs). I used https://api.adviceslip.com/ to generate the advice. Any help with these two questions would be amazing. Thanks!

    1. The icon (used to click and generate advice) seems to go inactive for a period of time while the data is being fetched. If I click the button twice in a row within a certain timeframe, the second click does nothing. Maybe this is normal because it takes some time to generate the data.

    2. For some reason, Firefox is giving me issues fetching data when clicking the icon. All other browsers work fine. Firefox will fetch the data and display it on startup. It will also fetch and work perfectly when I have the developer tools open. When I close the developer tools, the icon click no longer works, and I can't figure out why.

    Thanks for any help!

    Advice Generator App Using Tailwind & Fetch API

    2
    Emmanuel Oluwatobiloba•380
    @purrrpleliptonPosted about 1 year ago

    on the API's site i.e., api.adviceslip.com, it's said on there that sending multiple requests within 2 seconds will return the same advice as the firstly generated one is cached, so you have to wait 2s before clicking again will generate a different slip.

    Marked as helpful
    0
  • Emmanuel Oluwatobiloba•380
    @purrrpleliptonPosted almost 2 years ago

    the “Annual Plan” and the “Cancel Order” button seem to have the wrong color on :hover and the main section seems too small for desktop sizes

    0
  • Emmanuel Oluwatobiloba•380
    @purrrpleliptonPosted almost 2 years ago

    idk if it's just me, but the body isn't 100vh there's too much space at the bottom

    0