Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Caio Couto 150

    @CaioCouto

    Submitted

    Hello there!

    In this project I decided to go without any framework, just the good ol' semantic HTML5, CSS and Vanilla JS (I kind of enjoy doing things without the complexity of a framework).

    Although the challenge request the use of prefers-color-scheme, I solved the "save user selected theme" problem by using only LocalStorage.

    Any ideas on how I can improve the code (making it shorter, faster, using the best practices...) is welcome. Feel free to comment! :)

    Update: Following suggestion, improved how the ThemeSelector class' changeTheme() method works. Instead of going through the elements array twice, it now runs it only once.

    @pjooklas

    Posted

    calculator class makeOperation() i would use switch, not if/else if and why your number1 and 2 are strings, not number type?

    in ThemeSelector class changeTheme() method, you use forEach two times, you should make code to iterate only one tie, to add and to remove classes.

    Marked as helpful

    0
  • @pjooklas

    Posted

    Best solution I've seen.

    0
  • @pjooklas

    Posted

    Did you make it responsive? I don't see mobile version.

    1
  • @pjooklas

    Posted

    Hi there! Nice work, but I see You gave dashed border around, whicj wasn't on design. And it gets a bit too wide.

    Marked as helpful

    0