Skip to content
OverviewSolutions
2
Comments
3
Serena
@pixelRena

All comments

  • Serena•90
    @pixelRenaPosted almost 2 years ago

    Nice job, What's Missing: I noticed there weren't any hover actions for the buttons for your homepage (explore button), destination page (the sub navbar), and for the technology page (the number buttons). The figma file provided shows you what styling these buttons need when hovered.

    Marked as helpful
    0
  • KC•60
    @KC900201Submitted almost 2 years ago
    1. Difficulty in setting CSS configuration in React. Will consider using sass/scss in future
    2. Since react framework usage is the first try, will have to study on the react development cycle in the official site react-js.org
    3. Seeking professional guidance on React framework

    News homepage challenge using React

    1
    Serena•90
    @pixelRenaPosted almost 2 years ago

    Hello,

    A couple of improvements could be made to the CSS. I believe adding some padding to the body and adjusting the font-size a bit more could help make the layout.

    You mentioned you had troubles with the CSS in react, I am unable to view your code for a better outlook, but you could consider creating a styles or css folder in the "src" folder and contain all of your css there.

    As for importing css, this is by preference on where you want to import it. For example, if you want to use index.css, you can import it inside of App.js at the top of the file with: import "./styles/index.css";

    From there all of your components can use the css file.

    Marked as helpful
    0
  • Serena•90
    @pixelRenaPosted almost 2 years ago

    This looks great from the screenshot, and no error reports so that's even better. The only thing that is broken are your images whenever I go to the actual webpage, they do not appear. I noticed you don't have an assets folder. I would create an assets folder in the repository and add a images folder and place those images given to you.

    0