@gcarter89Submitted over 3 years ago
Any feedback is greatly appreciated; especially on how to condense the amount of CSS I used for this project.
Phil Jacks
@philjacksAll comments
- @philjacksPosted over 3 years ago
Great job with this mate! Design looks solid. I'm gunna attempt this one next.
I don't know if you have any experience with SASS but that allows you to break your css into smaller chunks across multiple files & can help tidy things up. Your CSS here looks sweet. Maybe open up a dev tools & see if that can highlight any potential improvements.
JS is nice & clean too.
1 - @aemann2Submitted over 3 years ago
I had fun with this one. I found the validation a little tricy, however. Does anyone have a good solution for how to do this kind of form validation? I feel like I over-engineered it...
@philjacksPosted over 3 years agoHey,
Awesome job on this. I've just finished this one & enjoyed it. I'd say your JS is bang on. I approached it slightly differently but wrote around the same amount of code. Maybe just check out those accessibility issues that the report has generated.
Job well done mate
2 - @etnlmySubmitted over 3 years ago
Hi, I would appreciate feedback on the CSS and on the custom form validation. Thanks :)
@philjacksPosted over 3 years agoHi friend!
CSS looks great & all the code is nice & clean. However, when I click the buttons the Javascript validation doesn't seem to work.
My suggestion would be to locate the eventListener for the form submit & add the preventDefault( ) method to stop the page refreshing.
I could be wrong (I'm still a newbie) but worth having a look.
1
