Phan Thành Chung
@phanthanhchungbyteAll comments
- @CooolCodes@phanthanhchungbyte
This is cool, but I think you need to work more on the spacing, good luck with the other projects!
Marked as helpful - P@giropa832What are you most proud of, and what would you do differently next time?
I am proud of finding an elegant solution to use javascript after a couple of iterations. Working with two divs in the mobile design and an array of buttons with the same eventListener and a toggle I believe is an elegant solution.
What challenges did you encounter, and how did you overcome them?The arrow on the floating share div probed troublesome until I finally found out how to do it. This time I did not match perfectly the design as I wanted to complete the challenge and move on.
What specific areas of your project would you like help with?Is the two divs solution wiht a toggle the best approach?
@phanthanhchungbyteYou did a great job on this one!
- P@TranDanh1122What specific areas of your project would you like help with?
First time deal with content format!, I spend ~3h on it :(! welcom any idea or comment thank you, have a nice day!!!!
@phanthanhchungbyteYou did great! But I think you should focus more on the text sizing, and also the card sizing as well.
Marked as helpful - @venkatesh-k-2002@phanthanhchungbyte
Good job bro, the proportion is correct. But try to make the card bigger next time. You can use a ruler in a Paint tool to manually find the dimension of the card pixel by pixel. Good luck!
- @samahbensafrar@phanthanhchungbyte
The card isn't centered on the screen. You should also make the image smaller to fit the design. Otherwise, it's a nice try.
- @Xerver8694What are you most proud of, and what would you do differently next time?
I had to relearn a lot of things about CSS Flexbox in order to get the appearance to match the preview. Looking through articles and videos helped quite a lot.
What challenges did you encounter, and how did you overcome them?Figuring out Flexbox to make the appearance match was the hardest part. Researching the properties and concepts helped a lot.
What specific areas of your project would you like help with?Everything seemed to work out fine in the end. I do not believe any help was needed for this simple project.
@phanthanhchungbyteWhen i visit the site, I found out that the text were out of the card, it spilled out. You may need to fix that.
You also don't really need flexbox for this project, although it seems like an interesting choice.