Skip to content
OverviewSolutions
21
Comments
6
perterHUAN
@perterHUAN

All comments

  • CodeHeaven•160
    @twobottles2092Submitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    This was my first challenge here so I am expecting a little mess but I am proud

    What challenges did you encounter, and how did you overcome them?

    The responsiveness and some elements I just knew when i coding

    What specific areas of your project would you like help with?

    Responsiveness

    Basics of Html and CSS

    2
    perterHUAN•250
    @perterHUANPosted 8 months ago

    On large screens, it looks acceptable, but there are some minor issues:

    • The preparation time section should have a greater margin from the bottom.
    • A suitable amount of spacing should be added between list items in the 'instructions' part, as they currently appear a bit cramped.
    • Padding should be added to the td elements within the nutrition table.

    The font-weight for the title "Simple Omelette Recipe" should be 400, not bold.

    For small screens, the performance is less satisfactory:

    • You should employ max-width instead of width, ensuring that the content doesn't overflow on smaller screens.
    • The padding around the photo should be absorbed by the photo itself on small screens; consider implementing negative margins to achieve this.
    • Rounded corners should be removed on small screens.
    Marked as helpful
    1
  • jhun•30
    @coding-jhuunnSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    using correct assets and show them

    myRecipePage

    1
    perterHUAN•250
    @perterHUANPosted 8 months ago

    Well done, but there's one detail overlooked: in unordered lists, when the content wraps onto multiple lines, the markers should also remain vertically centered.

    0
  • cchiem•150
    @cchiemSubmitted 8 months ago
    What specific areas of your project would you like help with?

    The nutrition table what is a better way, or can i use grid?

    Recipe Page

    1
    perterHUAN•250
    @perterHUANPosted 8 months ago

    On larger screens, it looks fine, but issues arise on smaller displays:

    1. When on smaller screens, the padding beside the photos should be removed; a negative margin can be utilized to achieve this effect.
    2. For list items, when their content wraps onto multiple lines, the markers at the beginning should also remain vertically centered.
    3. At smaller screen sizes, the contents of the table at the bottom get cramped together.
    0
  • perterHUAN•250
    @perterHUANPosted 8 months ago

    I cannot see your work. There seems to be a deployment issue.

    0
  • 6xg0d•190
    @6xg0dSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud that i spend most of my time with the CSS instead of HTML, i was way more comfortable to think the structure just by looking at the example.

    What challenges did you encounter, and how did you overcome them?

    One of the main problems that i had was positionating elements exactly where i want. Especially the space between the footer and the resume paragraph. I did think in a way to put the footer 24px away from the bottom using the row-gap property. Even when the space isn't exactly the same that the one in the design, i'm still pretty happy with the results, and looking forward to improve the code in the future.

    What specific areas of your project would you like help with?

    I want to know more about in which cases use margin or padding (even knowing the definitions in the practice in some cases i'm a little indecisive about which one should i use). Also, would like to know how to improve the CSS code and reduce the amount of lines or selectors to create the same results with the minimum amount of code possible

    Blog Preview Card Challenge Solution

    2
    perterHUAN•250
    @perterHUANPosted 8 months ago
    • Using flex combined with row-gap (actually, just using gap would suffice since there's no wrapping occurring here) on the article element to create spacing between child elements is a good method; elsewhere in the code, you could apply this approach instead of repeatedly using margin.
    • By setting a padding on the article, it eliminates the need to set margin-left and margin-right over and over again on the child elements.
    • I think it might be less appropriate to use header and footer here as they typically refer to headers or footers for the entire page rather than within the context used.
    • The hover animation seems to be missing; when the mouse hovers over the card, the box-shadow should shift downwards.
    • It's worth considering using CSS variables to standardize the spacing values throughout your stylesheet, making maintenance and modification more convenient.
    • This is my suggested solution; please note that I am not an expert, and I welcome your feedback and suggestions for discussion and mutual learning.
    Marked as helpful
    1
  • Khalifa Ltaief•80
    @khalifa-ltaiefSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    i used flex for the first time

    What challenges did you encounter, and how did you overcome them?

    i didn't know how flex work exactly but i started to know it

    What specific areas of your project would you like help with?

    nothing

    Mobile-first solution using CSS Flexbox

    2
    perterHUAN•250
    @perterHUANPosted 8 months ago

    1. There is a significant discrepancy between the solution and design specifications:

      • The content is not horizontally and vertically centered within the viewport.
      • The radius of the photos is excessively large, and there is too much space around them.
      • The font sizes are incorrect; the titles should be larger.
      • The style of the box-shadow is inappropriate.

    2. The HTML lacks semantic structure:

      • An abundance of div and span elements are used without clear semantic meaning.
      • Alt attributes are missing from the images.
      • Titles should be represented with h2 tags rather than spans.
      • Line breaks should be achieved naturally through text wrapping instead of using <br> tags.
    0