Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @perfidev

    Posted

    Very good! If you want to improve, use margin-top to align with the example and increase the padding a bit.

    1
  • Bshy201 80

    @Bshy201

    Submitted

    What challenges did you encounter, and how did you overcome them?

    Styling the list elements and structuring the whole HTML file in general. I had to look up how the list elements are usually styled.

    P

    @perfidev

    Posted

    Good job, my friend! It's normal to research how to style elements, don't worry about it. You're on the right track.

    Marked as helpful

    0
  • @gilotin

    Submitted

    What specific areas of your project would you like help with?

    I'm aiming to improve my HTML semantics skills, writing good quality CSS and BEM methodology skills.

    P

    @perfidev

    Posted

    Great job! That was a great idea to use <figure>. I think I'll use that too :)

    I would just place the links within a list for semantics.

    <ul class="main-list">
        <li class="main-list__item">
            <a href="#" target="_blank">Frontend Mentor</a>
        </li>
    </ul>
    

    Marked as helpful

    0
  • @Dumonster27

    Submitted

    What are you most proud of, and what would you do differently next time?

    Me orgulho de ter conseguido deixar pelo menos um pouco parecido com o original.

    What challenges did you encounter, and how did you overcome them?

    Alguns problemas de centralização, eu superei agrupando o título e o subtítulo em uma caixa flexível e adicionando caixa flexível

    What specific areas of your project would you like help with?

    Qualquer conselho sobre como se aproximar do original é muito bem vindo.

    P

    @perfidev

    Posted

    Ótimo trabalho! :) Somente por questões de semântica, eu colocaria todo o código dentro de uma tag <main> e usaria a tag <h1> ao invés da <h2>.

    <main>
        <div class="container">
        ...
        </div>
    </main>
    

    E no CSS adicionaria box-sizing: border-box no *, assim facilitaria para você calcular o tamanho dos elementos e o posicionamento.

    * {
            margin: 0;
            padding: 0;
            box-sizing: border-box;
    }
    

    Marked as helpful

    0
  • Jonathan 60

    @johnslayk

    Submitted

    What are you most proud of, and what would you do differently next time?

    Try to better resolve alignments between objects.

    What challenges did you encounter, and how did you overcome them?

    Align all the itens in the screen.

    What specific areas of your project would you like help with?

    Better control of padding and margin areas.

    P

    @perfidev

    Posted

    Great job! Try to follow the Figma file to adjust the paddings ;)

    0
  • P

    @perfidev

    Posted

    Hey, great job! For semantic purposes, place your code within the <main> tag and use <h1> for the main title of the page.

    Marked as helpful

    1
  • P

    @perfidev

    Posted

    Well done! You can use the :hover selector.

    a:hover { }
    

    Marked as helpful

    1
  • @JoeySalinas12

    Submitted

    • The submission format took some getting used to, but overall there was not too much difficulty in this project.
    • I could definitely use some practice using CSS.
    • One question: When incorporating javascript files, do those usually sit in their own folder or are the just referenced from the root folder?
    P

    @perfidev

    Posted

    Usually, you will separate the files into their own folders. Example of simple separation:

    • img (for images)
    • css (for css files)
    • js (for javascript files)
    • index.html

    Marked as helpful

    0
  • P

    @perfidev

    Posted

    You can align elements with CSS Grid using align-items (vertical) and justify-items (horizontal).

    You can also use Flexbox, using align-items (vertical) and justify-content (horizontal).

    And for the image, you can use border-radius.

    img { border-radius: 100px; }
    

    Suggestions:

    • Use box-sizing: border-box on *, so the browser will include the width and height of borders and padding in the total width and height calculation of the element.
    * {
            margin: 0;
            padding: 0;
            box-sizing: border-box;
    }
    
    • Add alt attribute to the image.
    <img src="perfil100px.jpg" alt="Pedro's photo" />
    
    • Place your content inside the <main> tag.
    <main>
        <div> ... </div>
    </main>
    

    Marked as helpful

    1
  • P

    @perfidev

    Posted

    Very well, my friend! It looks great! Here are some suggestions:

    • I would add "href" to the <a> tags because they are links and for best practices.
    • I would include a <nav> tag with a <ul> list and place the <a> links inside <li> tags, as it adds semantics since you are navigating through the links.
    • I would set the body as display: flex to center your <div>.
    <div class="box-botoes">
        <nav>
            <ul>
                <li><a href="https://github.com">Github</a></li>
                <li><a href="https://frontendmentor.io">Frontend Mentor</a></li>
                <li><a href="https://linkedin.com">LinkedIn</a></li>
                <li><a href="https://twitter.com">Twitter</a></li>
                <li><a href="https://instagram.com">Instagram</a></li>
            </ul>
        </nav>
    </div>
    

    Marked as helpful

    0
  • P

    @perfidev

    Posted

    Hi, you should use the <nav> with <ul>.

    <nav>
        <ul>
            <li><a href="#">Item 1</a></li>
            <li><a href="#">Item 2</a></li>
            <li><a href="#">Item 3</a></li>
        </ul>
    </nav>
    

    Marked as helpful

    0